Remove legacy IDB backend IPC glue for string-based references.

Remove legacy IDB backend IPC glue for string-based references.

Now that webkit is using the int64-based references for objects, remove the glue code.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167396

[alecflett, 2012-11-10 01:59:34]

I had to disable a test too because put() no longer has an 'ec' parameter - we
probably want to fix this in the frontend WebKit code, but I'm not sure how.

[dgrogan, 2012-11-12 19:25:18]

lgtm

Josh knows more about the max size test than I do.

https://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/pro...
File content/common/indexed_db/proxy_webidbdatabase_impl.h (right):

https://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/pro...
content/common/indexed_db/proxy_webidbdatabase_impl.h:38: virtual void
deleteObjectStore(
These 4 lines look identical to the next 4 lines?

[jsbell, 2012-11-12 19:38:50]

lgtm as well...

https://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/ind...
File content/common/indexed_db/indexed_db_dispatcher_unittest.cc (right):

https://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/ind...
content/common/indexed_db/indexed_db_dispatcher_unittest.cc:25: //
TODO(alecflett): Reenable this test when IDB code in webkit
Add a tracking bug for this and reference it?

See also:

content/browser/in_process_webkit/indexed_db_browsertest.cc:
// Appears flaky/slow, see: http://crbug.com/120298
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_ValueSizeTest) {

https://codereview.chromium.org/11312178/diff/4001/content/common/indexed_db/...
File content/common/indexed_db/indexed_db_dispatcher.cc (left):

https://codereview.chromium.org/11312178/diff/4001/content/common/indexed_db/...
content/common/indexed_db/indexed_db_dispatcher.cc:408: if (!value.is_null() &&
Definitely put in a tracking bug to reinstate this somehow.

If a different approach is taken (e.g. failing the request with an error),
WebKit::WebIDBDatabaseExceptionDataError can be removed from the webkit chromium
public API.

[alecflett, 2012-11-12 19:52:53]

http://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/prox...
File content/common/indexed_db/proxy_webidbdatabase_impl.h (right):

http://codereview.chromium.org/11312178/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbdatabase_impl.h:38: virtual void
deleteObjectStore(
On 2012/11/12 19:25:18, dgrogan wrote:
> These 4 lines look identical to the next 4 lines?

Very strange. look at the unified diff - it doesn't show that! Bug in rietveld?

[commit-bot: I haz the power, 2012-11-12 19:53:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11312178/3002

[commit-bot: I haz the power, 2012-11-12 19:53:30]

Presubmit check for 11312178-3002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common/indexed_db/indexed_db_messages.h

Presubmit checks took 4.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[alecflett, 2012-11-12 19:59:56]

inferno - quick review? removing old messages.

[Tom Sepez, 2012-11-12 21:53:29]

LGTM for removing messages.

[aarya, 2012-11-12 21:53:47]

Tom will take a look at the IPC stuff. Thanks Tom!

[commit-bot: I haz the power, 2012-11-12 22:38:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11312178/3002

[commit-bot: I haz the power, 2012-11-13 04:46:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11312178/3002

[commit-bot: I haz the power, 2012-11-13 14:30:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11312178/3002

[commit-bot: I haz the power, 2012-11-13 16:34:40]

Change committed as 167396