Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 11312072: Fix grit to substitute GRIT_DIR properly on Windows. (Closed)

Created:
8 years, 1 month ago by Sergey Ulanov
Modified:
8 years, 1 month ago
Reviewers:
tony, Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Fix grit to substitute GRIT_DIR properly on Windows. Previously GRIT_DIR was replaced with the current path only when it's followed by forward slash. GYP msvs generator replaces forward slashes with back slashes which breaks GRIT_DIR substitution. Fixed GRIT_DIR processing code to handle the case when GRIT_DIR is followed by back slash. Committed: https://code.google.com/p/grit-i18n/source/detail?r=84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M grit/node/misc.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sergey Ulanov
This should fix the issue I had when landing http://codereview.chromium.org/11275101/ (see http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/2896/steps/compile/logs/stdio )
8 years, 1 month ago (2012-11-02 20:49:42 UTC) #1
Jói
8 years, 1 month ago (2012-11-05 09:23:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698