Issue 113120: stub impl of linux,mac icon loader/manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113120: stub impl of linux,mac icon loader/manager (Closed)

Created:
11 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
idana

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Stub implementation of linux, mac icon loader/manager. Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15665

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : style fixes #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -116 lines)			Patch
M	chrome/browser/browser.vcproj	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/icon_loader.h	View	1 2 3	2 chunks	+28 lines, -7 lines	0 comments	Download
A	chrome/browser/icon_loader.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/browser/icon_loader_linux.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/browser/icon_loader_mac.mm	View		1 chunk	+15 lines, -0 lines	0 comments	Download
D	chrome/browser/icon_loader_win.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/icon_loader_win.cc	View	1	4 chunks	+4 lines, -35 lines	0 comments	Download
M	chrome/browser/icon_manager.h	View	1 2 3	4 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/icon_manager.cc	View		4 chunks	+10 lines, -22 lines	0 comments	Download
A	chrome/browser/icon_manager_linux.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/browser/icon_manager_mac.mm	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/browser/icon_manager_win.cc	View	2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I've backtracked a little bit with this patch. I decided the only place IconLoader need ...

11 years, 7 months ago (2009-05-07 21:53:56 UTC) #1

LGTM

Expand Messages | Collapse Messages