Issue 113114: OS X Breakpad cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113114: OS X Breakpad cleanup. (Closed)

Created:
11 years, 7 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski

Visibility:
Public.

Description

OS X Breakpad cleanup. * Compile OS X dump_syms & symupload utilities from the public repository to simplify the branded builder. * Correct comment in breakpad_mac_stubs.mm so it more accurately reflects reality.

Patch Set 1 #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
	M	breakpad/breakpad.gyp	View		1 chunk	+40 lines, -0 lines	3 comments	Download
	M	chrome/app/breakpad_mac_stubs.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm Not sure what the "Update bug numbers in test_expectations." comment in the cl description ...

11 years, 7 months ago (2009-05-07 19:49:37 UTC) #2

Mark Mentovai

11 years, 7 months ago (2009-05-07 19:54:09 UTC) #3

lg

http://codereview.chromium.org/113114/diff/1/2
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/113114/diff/1/2#newcode95
Line 95: 'src/common/mac/',
It is customary to not use a trailing slash.

http://codereview.chromium.org/113114/diff/1/2#newcode117
Line 117: 'src/common/mac/',
Same.

http://codereview.chromium.org/113114/diff/1/2#newcode136
Line 136: 'dump_syms',
libbreakpad does not depend on dump_syms or symupload.  Please take these out.

The automatically-generated "All" target in breakpad.xcodeproj will build
libbreakpad, dump_syms, and symupload.  So will the automatically-generated
all.gyp:all target.

Expand Messages | Collapse Messages