Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113086: Change CaptureSVNInfo() to return a dictionary instead of a object. (Closed)

Created:
11 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change CaptureSVNInfo() to return a dictionary instead of a object. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15750

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -30 lines) Patch
M gclient.py View 1 4 chunks +33 lines, -19 lines 0 comments Download
M tests/gclient_test.py View 1 3 chunks +55 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 7 months ago (2009-05-07 04:57:14 UTC) #1
bradn
LGTM Too bad it drops down into a dict, but at least you have tests ...
11 years, 7 months ago (2009-05-07 18:16:30 UTC) #2
M-A Ruel
11 years, 7 months ago (2009-05-09 04:45:55 UTC) #3 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698