chrome/renderer/external_extension.cc - Issue 113085: Split V8Proxy::retrieveActiveFrame() into two methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/external_extension.cc

Issue 113085: Split V8Proxy::retrieveActiveFrame() into two methods. (Closed)

Patch Set: Darin feedback Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/external_extension.cc

diff --git a/chrome/renderer/external_extension.cc b/chrome/renderer/external_extension.cc

index 378e78e9f58ca2c531a5b3439e62c0ef70342f9a..100f311fd08978e8bfaf3bc85915653cb46ef06c 100644

--- a/chrome/renderer/external_extension.cc

+++ b/chrome/renderer/external_extension.cc

@@ -35,7 +35,7 @@ class ExternalExtensionWrapper : public v8::Extension {

if (!args.Length())

return v8::Undefined();

- WebFrame* webframe = WebFrame::RetrieveActiveFrame();

+ WebFrame* webframe = WebFrame::RetrieveFrameForEnteredContext();

DCHECK(webframe) << "There should be an active frame since we just got "

"a native function called.";

if (!webframe) return v8::Undefined();