Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: chrome/renderer/extensions/bindings_utils.cc

Issue 113085: Split V8Proxy::retrieveActiveFrame() into two methods. (Closed)
Patch Set: Darin feedback Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/bindings_utils.h" 5 #include "chrome/renderer/extensions/bindings_utils.h"
6 6
7 #include "chrome/renderer/render_view.h" 7 #include "chrome/renderer/render_view.h"
8 #include "webkit/glue/webframe.h" 8 #include "webkit/glue/webframe.h"
9 9
10 RenderView* GetActiveRenderView() { 10 RenderView* GetRenderViewForCurrentContext() {
11 WebFrame* webframe = WebFrame::RetrieveActiveFrame(); 11 WebFrame* webframe = WebFrame::RetrieveFrameForCurrentContext();
12 DCHECK(webframe) << "GetActiveRenderView called when not in a V8 context."; 12 DCHECK(webframe) << "RetrieveCurrentFrame called when not in a V8 context.";
13 if (!webframe) 13 if (!webframe)
14 return NULL; 14 return NULL;
15 15
16 WebView* webview = webframe->GetView(); 16 WebView* webview = webframe->GetView();
17 if (!webview) 17 if (!webview)
18 return NULL; // can happen during closing 18 return NULL; // can happen during closing
19 19
20 RenderView* renderview = static_cast<RenderView*>(webview->GetDelegate()); 20 RenderView* renderview = static_cast<RenderView*>(webview->GetDelegate());
21 DCHECK(renderview) << "Encountered a WebView without a WebViewDelegate"; 21 DCHECK(renderview) << "Encountered a WebView without a WebViewDelegate";
22 return renderview; 22 return renderview;
23 } 23 }
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/bindings_utils.h ('k') | chrome/renderer/extensions/extension_process_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698