Issue 113068: The ARM assembler tests don't install the standard JS natives. When...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113068: The ARM assembler tests don't install the standard JS natives. When... (Closed)

Created:
11 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

The ARM assembler tests don't install the standard JS natives. When setting up push and pop we shouldn't make too many assumptions about the structure of classes like 'Array'. Committed: http://code.google.com/p/v8/source/detail?r=1888

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	src/bootstrapper.cc	View		1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

11 years, 7 months ago (2009-05-07 00:04:52 UTC) #2

The CL looks fine to me, and the problem applies both platform. I think our
approach is fragile that requires coordination between JS code and native code.

Expand Messages | Collapse Messages