Support TSF related event handling on NativeTextField

chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
index 3023d56936f297b4cca1991c241b5c8b75dd72c8..1ddfbbb03db6eb97cea9c4aa29626640a7377297 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
@@ -917,7 +917,7 @@ bool OmniboxViewWin::OnAfterPossibleChangeInternal(bool force_text_changed) {
   return something_changed;
 }
 
-void OmniboxViewWin::OnTextUpdated() {
+void OmniboxViewWin::OnTextUpdated(const ui::Range& /*composition_range*/) {
   if (ignore_ime_messages_)
     return;
   OnAfterPossibleChangeInternal(true);
@@ -928,6 +928,10 @@ void OmniboxViewWin::OnTextUpdated() {
   OnBeforePossibleChange();
 }
 
+void OmniboxViewWin::OnTsfStartComposition() {}

[Peter Kasting, 2012/10/27 19:00:46]

Does this message give us what we need in order to remove the
OnBeforePossibleChange() call in OnTextUpdated()?

[Seigo Nonaka, 2012/10/27 22:20:18]

Unfortunately no, because OnTsfstartComosition is called after TSF changes
texts, so it's too late to call OnBeforePossibleChange.
Furthermore, we should call OnBeforePossibleChange every before the text updates
but OnTsfStartComposition is only called when the composition is created. Some
input tools (e.g. on-screen keyboard on Win 8) put characters without
composition.

FYI: Editing session is different concept from composition start/end. TSF may
make/update/terminate composition string in each editing session. Compared to
omnibox, find-bar should suppress incremental search if the query string is
composition string. To keep current implementation, I introduced
OnTsfStartComposition/OnTsfEndComposition callbacks as substitute for
WM_IME_STARTCOMPOSITION/WM_IME_END_COMPOSITION which is used in non-Metro mode.

On 2012/10/27 19:00:46, Peter Kasting wrote:

+
+void OmniboxViewWin::OnTsfEndComposition() {}
+
 void OmniboxViewWin::OnCandidateWindowCountChanged(size_t window_count) {
   ime_candidate_window_open_ = (window_count != 0);
   if (ime_candidate_window_open_) {