Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/app/chrome_dll_main.cc

Issue 113043: Fix gconf for the linux proxy config service.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/chrome_url_request_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_dll_main.cc
===================================================================
--- chrome/app/chrome_dll_main.cc (revision 16488)
+++ chrome/app/chrome_dll_main.cc (working copy)
@@ -466,18 +466,12 @@
#endif
} else if (process_type.empty()) {
#if defined(OS_LINUX)
- // Glib/GDK type system and threading initializations. Needed at
- // least for gconf usage in net/proxy/proxy_config_service_linux.cc.
- // TODO(sdoyon): confirm whether gconf truly needs this. If so,
- // the GTK main loop (message pump) must also be made to call
- // gdk_threads_enter/leave(). Similar issue with the clipboard
- // (estade@ deanm@).
+ // Glib type system initialization. Needed at least for gconf,
+ // used in net/proxy/proxy_config_service_linux.cc. Most likely
+ // this is superfluous as gtk_init() ought to do this. It's
+ // definitely harmless, so retained as a reminder of this
+ // requirement for gconf.
g_type_init();
-#if 0 // gconf temporarily disabled because of races.
- // See http://crbug.com/11442.
- g_thread_init(NULL);
- gdk_threads_init();
-#endif // 0 (gconf disabled)
// gtk_init() can change |argc| and |argv|, but nobody else uses them.
gtk_init(&argc, const_cast<char***>(&argv));
SetUpGLibLogHandler();
« no previous file with comments | « no previous file | chrome/browser/net/chrome_url_request_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698