Make check in GetExternalString a runtime check instead of ASSERT....

Make check in GetExternalString a runtime check instead of ASSERT.
This will allow us to remove the separate call to IsExternal() from our
chrome client code, speeding up the combination.


Committed: http://code.google.com/p/v8/source/detail?r=1887

[iposva, 2009-05-06 18:04:44]

Please update the documentation in include/v8.h as well.

-Ivan

[DaveMoore, 2009-05-06 18:14:28]

I also added a change to cache whether we're initialized, allowing us to inline
that and avoid the deadchecks when we are.

[DaveMoore, 2009-05-06 18:18:09]

Done
On 2009/05/06 18:04:44, iposva wrote:
> Please update the documentation in include/v8.h as well.
> 
> -Ivan

[iposva, 2009-05-06 18:20:05]

http://codereview.chromium.org/113035/diff/1002/1003
File src/api.cc (right):

http://codereview.chromium.org/113035/diff/1002/1003#newcode211
Line 211: if (IsDeadCheck(location)) return;
This optimization will not work because the IsDeadCheck is supposed to guard
against a V8 that has been initialized but has shutdown later. With your
optimization you are going to skip that test entirely meaning you will never
figure out that you are calling into a V8 that has already shutdown.

Please roll optimizations to this into a separate change list as it has nothing
to do with fast access to external strings.

[DaveMoore, 2009-05-06 18:23:31]

Done.
On 2009/05/06 18:20:05, iposva wrote:
> http://codereview.chromium.org/113035/diff/1002/1003
> File src/api.cc (right):
> 
> http://codereview.chromium.org/113035/diff/1002/1003#newcode211
> Line 211: if (IsDeadCheck(location)) return;
> This optimization will not work because the IsDeadCheck is supposed to guard
> against a V8 that has been initialized but has shutdown later. With your
> optimization you are going to skip that test entirely meaning you will never
> figure out that you are calling into a V8 that has already shutdown.
> 
> Please roll optimizations to this into a separate change list as it has
nothing
> to do with fast access to external strings.

[iposva, 2009-05-06 18:26:20]

LGTM -ip