Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 113030: X64: Fixed conversion between tread_id (int) and void*. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64: Fixed conversion between tread_id (int) and void*. Thread id's are always int size values (generated from an int counter).

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/platform.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/v8threads.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Thread id's are always int. Fixed conversion to and from void*. Review please.
11 years, 7 months ago (2009-05-06 12:28:37 UTC) #1
Dean McNamee
http://codereview.chromium.org/113030/diff/1/2 File src/v8threads.cc (right): http://codereview.chromium.org/113030/diff/1/2#newcode312 Line 312: void* stored_thread_id = Thread::GetThreadLocal(thread_id_key); I would add to ...
11 years, 7 months ago (2009-05-06 12:54:39 UTC) #2
Dean McNamee
11 years, 7 months ago (2009-05-06 13:00:10 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698