X64: Made hash computation in serializer accept 64-bit pointers.

X64: Made hash computation in serializer accept 64-bit pointers.
Also changed api Wrap function to only wrap suitably small pointers as Smis.
Added Smi validity check and factory meethod for intptr_t.

[Lasse Reichstein, 2009-05-06 07:25:55]

Quick review.

[William Hesse, 2009-05-06 07:42:37]

LGTM.

http://codereview.chromium.org/113023/diff/1/3
File src/objects-inl.h (right):

http://codereview.chromium.org/113023/diff/1/3#newcode801
Line 801: ((static_cast<uintptr_t>(value) + 0x40000000U) < 0x80000000U);
If this is safe, why not change the test in IsValid to agree with it.

http://codereview.chromium.org/113023/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/113023/diff/1/4#newcode790
Line 790: static inline bool IsPtrValid(intptr_t);
Perhaps this should be IsIntptrValid, and we may or may not want IsPtrValid that
takes a void pointer as argument.  It may save some casting, and can be inlined.

[Lasse Reichstein, 2009-05-12 08:16:38]

http://codereview.chromium.org/113023/diff/1/3
File src/objects-inl.h (right):

http://codereview.chromium.org/113023/diff/1/3#newcode801
Line 801: ((static_cast<uintptr_t>(value) + 0x40000000U) < 0x80000000U);
Only the assumption that the and is slightly faster than the compare, but using
less-than allows me to use a intptr_t size independent constant (as long as Smis
are 31 bit).

http://codereview.chromium.org/113023/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/113023/diff/1/4#newcode790
Line 790: static inline bool IsPtrValid(intptr_t);
On 2009/05/06 07:42:37, William Hesse wrote:
> Perhaps this should be IsIntptrValid, and we may or may not want IsPtrValid
that
> takes a void pointer as argument.  It may save some casting, and can be
inlined.
>  

Done.