Issue 11302: fix pan scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11302: fix pan scrolling (Closed)

Created:
12 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Evan Martin, ojan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

fix pan scrolling The ScrollView tries to load an image before setting the cursor to a pan scroll cursor. Not sure why this is needed, but add the image so it works.

Patch Set 1 #

Patch Set 2 : copy png #

Patch Set 3 : pan_icon #

Patch Set 4 : add file #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3 lines)			Patch
M	webkit/glue/chromium_bridge_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/resources/README.txt	View	2	2 chunks	+50 lines, -4 lines	0 comments	Download
A	webkit/glue/resources/pan_icon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/glue/webkit_resources.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webkit_resources.rc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

LGTM It's a bit weird to pull in WebKit/WebKit files, but it's just a png, ...

12 years, 1 month ago (2008-11-20 01:37:45 UTC) #2

tony

Updated to put a copy of the png in our tree. Take another look? On ...

12 years, 1 month ago (2008-11-20 08:53:34 UTC) #3

darin (slow to review)

12 years, 1 month ago (2008-11-20 08:56:12 UTC) #4

LG

http://codereview.chromium.org/11302/diff/201/11
File webkit/glue/resources/README.txt (right):

http://codereview.chromium.org/11302/diff/201/11#newcode59
Line 59: panIcon.png
can you name this pan_icon.png?  by the way, glen said he was _very_ interested
in creating nicer versions of these images.

Expand Messages | Collapse Messages