Issue 113001: Separate the key setting code in the constructor of HMAC class into the Init...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113001: Separate the key setting code in the constructor of HMAC class into the Init... (Closed)

Created:
11 years, 7 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Separate the key setting code in the constructor of HMAC class into the Init method. Overload the Init method for char* and std::string. Add DCHECKs to the destruction methods in ~HMAC in hmac_win.cc. The patch is written by Takeshi Yoshino <tyoshino@google.com>;. Original code review: http://codereview.chromium.org/88062 R=wtc http://crbug.com/2297 TEST=base_unittests should pass. Safe browsing should continue to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15353

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -25 lines)			Patch
M	base/hmac.h	View	1 chunk	+15 lines, -4 lines	0 comments	Download
M	base/hmac_mac.cc	View	1 chunk	+14 lines, -1 line	0 comments	Download
M	base/hmac_nss.cc	View	3 chunks	+31 lines, -3 lines	0 comments	Download
M	base/hmac_unittest.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	base/hmac_win.cc	View	2 chunks	+33 lines, -8 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download