Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11299081: Revert 168603 - Beginnings of moving more stuff from build_sdk.py to GYP. (Closed)

Created:
8 years, 1 month ago by binji
Modified:
8 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 168603 - Beginnings of moving more stuff from build_sdk.py to GYP. Adds a new target to all.gyp: chromium_builder_nacl_sdk Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the native_client repo, but also builds and copies ppapi libraries to the toolchain directories. Retry of http://codereview.chromium.org/11363045/ This originally failed here: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/41342 With the following error: init.c:(.text+0x3c): undefined reference to `__libc_setup_tls' init.c:(.text+0x2e2): undefined reference to `_dl_init_static_tls' init.c:(.text+0x2ec): undefined reference to `_dl_wait_lookup_done' While building simple_glibc_x86_32.nexe. My change seems to have tickled a bug in nacl_browser_test.gypi which was using the link flag -lpthread instead of -pthread. Changing this seems to have fixed the link failure. BUG=none TBR=noelallen@chromium.org TBR=ncbray@chromium.org Review URL: https://codereview.chromium.org/11280063 TBR=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -146 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/test/data/nacl/nacl_browser_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/build_tools/nacl_ppapi_sdk.gyp View 1 chunk +0 lines, -130 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
binji
8 years, 1 month ago (2012-11-19 21:23:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698