Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3819)

Unified Diff: chrome/browser/api/prefs/pref_member.h

Issue 11293249: Remove PrefObserver usage, batch 3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make a couple of accessors public. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/public/pref_change_registrar.cc ('k') | chrome/browser/chromeos/preferences.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/api/prefs/pref_member.h
diff --git a/chrome/browser/api/prefs/pref_member.h b/chrome/browser/api/prefs/pref_member.h
index 5f3791cf19659585c7663c202e26f5d8ad278596..da249e4bf814e1fa1d04256b7cae82a13348b0cd 100644
--- a/chrome/browser/api/prefs/pref_member.h
+++ b/chrome/browser/api/prefs/pref_member.h
@@ -47,6 +47,10 @@ class PrefMemberBase : public PrefObserver {
// the pref that is changing.
typedef base::Callback<void(const std::string&)> NamedChangeCallback;
+ const std::string& pref_name() const { return pref_name_; }
Mattias Nissler (ping if slow) 2012/11/13 15:47:03 Note that there already is a public GetPrefName in
Jói 2012/11/13 16:28:24 Right you are, sorry I didn't notice. Moved this
+ PrefServiceBase* prefs() { return prefs_; }
+ const PrefServiceBase* prefs() const { return prefs_; }
+
protected:
class Internal : public base::RefCountedThreadSafe<Internal> {
public:
@@ -124,10 +128,6 @@ class PrefMemberBase : public PrefObserver {
// it hasn't been loaded yet.
void VerifyPref() const;
- const std::string& pref_name() const { return pref_name_; }
- PrefServiceBase* prefs() { return prefs_; }
- const PrefServiceBase* prefs() const { return prefs_; }
-
virtual Internal* internal() const = 0;
// Used to allow registering plain base::Closure callbacks.
« no previous file with comments | « base/prefs/public/pref_change_registrar.cc ('k') | chrome/browser/chromeos/preferences.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698