Make DriveFeedProcessor asynchronous.

chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc

Index: chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc
===================================================================
--- chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc	(revision 167238)
+++ chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc	(working copy)
@@ -34,6 +34,11 @@
   EXPECT_EQ(expected_error, actual_error);
 }
 
+void OnGetChangedDirectories(std::set<FilePath>* out_changed_directories,
+                             const std::set<FilePath>& in_changed_directories) {
+  *out_changed_directories = in_changed_directories;
+}
+
 }  // namespace
 
 class DriveResourceMetadataTest : public testing::Test {
@@ -41,6 +46,10 @@
   DriveResourceMetadataTest();
 
  protected:
+  DriveEntryProto CreateDriveEntryProto(int sequence_id,
+                                        bool is_directory,
+                                        const std::string& parent_resource_id);
+
   DriveResourceMetadata resource_metadata_;
 
  private:
@@ -93,11 +102,36 @@
   AddFile(dir3, sequence_id++);
 }
 
+DriveEntryProto DriveResourceMetadataTest::CreateDriveEntryProto(
+    int sequence_id,
+    bool is_directory,
+    const std::string& parent_resource_id) {
+  DriveEntryProto entry_proto;
+  const std::string sequence_id_str = base::IntToString(sequence_id);
+  const std::string title = (is_directory ? "dir" : "file") +
+                                sequence_id_str;
+  const std::string resource_id = "resource_id:" + title;
+  entry_proto.set_title(title);
+  entry_proto.set_resource_id(resource_id);
+  entry_proto.set_parent_resource_id(parent_resource_id);
+
+  PlatformFileInfoProto* file_info = entry_proto.mutable_file_info();
+  file_info->set_is_directory(is_directory);
+
+  if (!is_directory) {
+    DriveFileSpecificInfo* file_specific_info =
+        entry_proto.mutable_file_specific_info();
+    file_info->set_size(sequence_id * 1024);
+    file_specific_info->set_file_md5(std::string("md5:") + title);
+  }
+  return entry_proto;
+}
+
 DriveDirectory* DriveResourceMetadataTest::AddDirectory(DriveDirectory* parent,
                                                         int sequence_id) {
   scoped_ptr<DriveDirectory> dir = resource_metadata_.CreateDriveDirectory();
   const std::string dir_name = "dir" + base::IntToString(sequence_id);
-  const std::string resource_id = std::string("dir_resource_id:") + dir_name;
+  const std::string resource_id = std::string("resource_id:") + dir_name;
   dir->set_title(dir_name);
   dir->set_resource_id(resource_id);
 
@@ -110,10 +144,10 @@
                                               int sequence_id) {
   scoped_ptr<DriveFile> file = resource_metadata_.CreateDriveFile();
   const std::string title = "file" + base::IntToString(sequence_id);
-  const std::string resource_id = std::string("file_resource_id:") + title;
+  const std::string resource_id = std::string("resource_id:") + title;
   file->set_title(title);
   file->set_resource_id(resource_id);
-  file->set_file_md5(std::string("file_md5:") + title);
+  file->set_file_md5(std::string("md5:") + title);
 
   parent->AddEntry(file.get());
 
@@ -177,7 +211,7 @@
   FilePath drive_file_path;
   scoped_ptr<DriveEntryProto> entry_proto;
   resource_metadata_.GetEntryInfoByResourceId(
-      "file_resource_id:file4",
+      "resource_id:file4",
       base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
                  &error, &drive_file_path, &entry_proto));
   google_apis::test_util::RunBlockingPoolTask();
@@ -381,7 +415,7 @@
   // Make sure file9 is found.
   DriveFileError error = DRIVE_FILE_ERROR_FAILED;
   FilePath drive_file_path;
-  const std::string file9_resource_id = "file_resource_id:file9";
+  const std::string file9_resource_id = "resource_id:file9";
   scoped_ptr<DriveEntryProto> entry_proto;
   resource_metadata_.GetEntryInfoByResourceId(
       file9_resource_id,
@@ -412,7 +446,7 @@
   EXPECT_FALSE(entry_proto.get());
 
   // Look for dir3.
-  const std::string dir3_resource_id = "dir_resource_id:dir3";
+  const std::string dir3_resource_id = "resource_id:dir3";
   resource_metadata_.GetEntryInfoByResourceId(
       dir3_resource_id,
       base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
@@ -475,7 +509,7 @@
 
   // Look up the entry by its resource id and make sure it really moved.
   resource_metadata_.GetEntryInfoByResourceId(
-      "file_resource_id:file8",
+      "resource_id:file8",
       base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
                  &error, &drive_file_path, &entry_proto));
   google_apis::test_util::RunBlockingPoolTask();
@@ -534,7 +568,7 @@
 
   // Make sure file is still ok.
   resource_metadata_.GetEntryInfoByResourceId(
-      "file_resource_id:file8",
+      "resource_id:file8",
       base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
                  &error, &drive_file_path, &entry_proto));
   google_apis::test_util::RunBlockingPoolTask();
@@ -559,7 +593,7 @@
 
   // Lookup the file by resource id to make sure the file actually got renamed.
   resource_metadata_.GetEntryInfoByResourceId(
-      "file_resource_id:file8",
+      "resource_id:file8",
       base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
                  &error, &drive_file_path, &entry_proto));
   google_apis::test_util::RunBlockingPoolTask();
@@ -597,6 +631,194 @@
   EXPECT_EQ(FilePath(), drive_file_path);
 }
 
+TEST_F(DriveResourceMetadataTest, RefreshEntryProto) {
+  DriveFileError error = DRIVE_FILE_ERROR_FAILED;
+  FilePath drive_file_path;
+  scoped_ptr<DriveEntryProto> entry_proto;
+
+  // Get file9.
+  resource_metadata_.GetEntryInfoByPath(
+      FilePath::FromUTF8Unsafe("drive/dir1/dir3/file9"),
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoCallback,
+                 &error, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("file9", entry_proto->base_name());
+  ASSERT_TRUE(entry_proto->has_file_specific_info());
+  EXPECT_EQ("md5:file9", entry_proto->file_specific_info().file_md5());
+
+  // Rename it and change the file size.
+  DriveEntryProto file_entry_proto(*entry_proto);
+  const std::string updated_md5("md5:updated");
+  file_entry_proto.mutable_file_specific_info()->set_file_md5(updated_md5);
+  file_entry_proto.set_title("file100");
+  entry_proto.reset();
+  resource_metadata_.RefreshEntryProto(
+      file_entry_proto,
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
+                 &error, &drive_file_path, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  EXPECT_EQ(FilePath::FromUTF8Unsafe("drive/dir1/dir3/file100"),
+            drive_file_path);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("file100", entry_proto->base_name());
+  ASSERT_TRUE(entry_proto->has_file_specific_info());
+  EXPECT_EQ(updated_md5, entry_proto->file_specific_info().file_md5());
+
+  // Make sure we get the same thing from GetEntryInfoByPath.
+  entry_proto.reset();
+  resource_metadata_.GetEntryInfoByPath(
+      FilePath::FromUTF8Unsafe("drive/dir1/dir3/file100"),
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoCallback,
+                 &error, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("file100", entry_proto->base_name());
+  ASSERT_TRUE(entry_proto->has_file_specific_info());
+  EXPECT_EQ(updated_md5, entry_proto->file_specific_info().file_md5());
+
+  // Get dir2.
+  entry_proto.reset();
+  resource_metadata_.GetEntryInfoByPath(
+      FilePath::FromUTF8Unsafe("drive/dir2"),
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoCallback,
+                 &error, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("dir2", entry_proto->base_name());
+  ASSERT_TRUE(entry_proto->file_info().is_directory());
+
+  // Change the name to dir100 and change the parent to drive/dir1/dir3.
+  DriveEntryProto dir_entry_proto(*entry_proto);
+  dir_entry_proto.set_title("dir100");
+  dir_entry_proto.set_parent_resource_id("resource_id:dir3");
+  entry_proto.reset();
+  resource_metadata_.RefreshEntryProto(
+      dir_entry_proto,
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoWithFilePathCallback,
+                 &error, &drive_file_path, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  EXPECT_EQ(FilePath::FromUTF8Unsafe("drive/dir1/dir3/dir100"),
+            drive_file_path);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("dir100", entry_proto->base_name());
+  EXPECT_TRUE(entry_proto->file_info().is_directory());
+  EXPECT_EQ("resource_id:dir2", entry_proto->resource_id());
+
+  // Make sure the children have moved over. Test file6.
+  entry_proto.reset();
+  resource_metadata_.GetEntryInfoByPath(
+      FilePath::FromUTF8Unsafe("drive/dir1/dir3/dir100/file6"),
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoCallback,
+                 &error, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  ASSERT_TRUE(entry_proto.get());
+  EXPECT_EQ("file6", entry_proto->base_name());
+
+  // Make sure dir2 no longer exists.
+  resource_metadata_.GetEntryInfoByPath(
+      FilePath::FromUTF8Unsafe("drive/dir2"),
+      base::Bind(&test_util::CopyResultsFromGetEntryInfoCallback,
+                 &error, &entry_proto));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_ERROR_NOT_FOUND, error);
+  EXPECT_FALSE(entry_proto.get());
+}
+
+TEST_F(DriveResourceMetadataTest, AddEntryToParent) {
+  int sequence_id = 100;
+  DriveEntryProto file_entry_proto = CreateDriveEntryProto(
+      sequence_id++, false, "resource_id:dir3");
+
+  DriveFileError error = DRIVE_FILE_ERROR_FAILED;
+  FilePath drive_file_path;
+
+  // Add to dir3.
+  resource_metadata_.AddEntryToParent(
+      file_entry_proto,
+      base::Bind(&test_util::CopyResultsFromFileMoveCallback,
+                 &error, &drive_file_path));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  EXPECT_EQ(FilePath::FromUTF8Unsafe("drive/dir1/dir3/file100"),
+            drive_file_path);
+
+  // Adds to root when parent resource id is not specified.
+  DriveEntryProto file_entry_proto2 = CreateDriveEntryProto(
+      sequence_id++, false, "");
+
+  resource_metadata_.AddEntryToParent(
+      file_entry_proto2,
+      base::Bind(&test_util::CopyResultsFromFileMoveCallback,
+                 &error, &drive_file_path));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  EXPECT_EQ(FilePath::FromUTF8Unsafe("drive/file101"), drive_file_path);
+
+  // Add a directory.
+  DriveEntryProto dir_entry_proto = CreateDriveEntryProto(
+      sequence_id++, true, "resource_id:dir1");
+
+  resource_metadata_.AddEntryToParent(
+      dir_entry_proto,
+      base::Bind(&test_util::CopyResultsFromFileMoveCallback,
+                 &error, &drive_file_path));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_OK, error);
+  EXPECT_EQ(FilePath::FromUTF8Unsafe("drive/dir1/dir102"), drive_file_path);
+
+  // Add to an invalid parent.
+  DriveEntryProto file_entry_proto3 = CreateDriveEntryProto(
+      sequence_id++, false, "resource_id:invalid");
+
+  resource_metadata_.AddEntryToParent(
+      file_entry_proto3,
+      base::Bind(&test_util::CopyResultsFromFileMoveCallback,
+                 &error, &drive_file_path));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(DRIVE_FILE_ERROR_NOT_FOUND, error);
+}
+
+TEST_F(DriveResourceMetadataTest, GetChangedDirectories) {
+  std::set<FilePath> changed_directories;
+
+  // file9: only drive/dir1/dir3 is affected.
+  resource_metadata_.GetChangedDirectories("resource_id:file9",
+      base::Bind(&OnGetChangedDirectories, &changed_directories));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(1u, changed_directories.size());
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive/dir1/dir3")));
+
+  // dir2: root and dir2 are affected.
+  resource_metadata_.GetChangedDirectories("resource_id:dir2",
+      base::Bind(&OnGetChangedDirectories, &changed_directories));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(2u, changed_directories.size());
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive")));
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive/dir2")));
+
+  // dir1: root, dir1, and dir3 are affected.
+  resource_metadata_.GetChangedDirectories("resource_id:dir1",
+      base::Bind(&OnGetChangedDirectories, &changed_directories));
+  google_apis::test_util::RunBlockingPoolTask();
+  EXPECT_EQ(3u, changed_directories.size());
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive")));
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive/dir1")));
+  EXPECT_EQ(1u, changed_directories.count(
+      FilePath::FromUTF8Unsafe("drive/dir1/dir3")));
+}
+
 TEST_F(DriveResourceMetadataTest, TakeOverEntries) {
   DriveFileError error = DRIVE_FILE_ERROR_FAILED;
   FilePath drive_file_path;
@@ -604,8 +826,8 @@
 
   // Move files from dir1 to dir2.
   resource_metadata_.TakeOverEntries(
-      "dir_resource_id:dir1",
-      "dir_resource_id:dir2",
+      "resource_id:dir1",
+      "resource_id:dir2",
       base::Bind(&test_util::CopyResultsFromFileMoveCallback,
                  &error, &drive_file_path));
   google_apis::test_util::RunBlockingPoolTask();