Make DriveFeedProcessor asynchronous.

chrome/browser/chromeos/drive/drive_file_system_unittest.cc

Index: chrome/browser/chromeos/drive/drive_file_system_unittest.cc
===================================================================
--- chrome/browser/chromeos/drive/drive_file_system_unittest.cc	(revision 167238)
+++ chrome/browser/chromeos/drive/drive_file_system_unittest.cc	(working copy)
@@ -1026,7 +1026,6 @@
       EntryExists(FilePath(FILE_PATH_LITERAL("drive/Added file.gdoc"))));
 }
 
-
 TEST_F(DriveFileSystemTest, ChangeFeed_AddAndDeleteFileFromExistingDirectory) {
   int latest_changelog = 0;
   ASSERT_TRUE(LoadRootFeedDocument("gdata/root_feed.json"));
@@ -1039,6 +1038,13 @@
       Eq(FilePath(FILE_PATH_LITERAL("drive"))))).Times(1);
   EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(
       Eq(FilePath(FILE_PATH_LITERAL("drive/Directory 1"))))).Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL("drive/Directory 1/Sub Directory Folder")))))
+      .Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL(
+          "drive/Directory 1/Sub Directory Folder/Sub Sub Directory Folder")))))
+      .Times(1);

[satorux1, 2012/11/15 01:49:10]

I'm confused. Here, two things are tested:

1) "Added file.gdoc" is added in "drive/Directory 1" by applying
"delta_file_added_in_directory.json"

2) "Added file.gdoc" is deleted in "drive/Directory 1" by applying
"delta_file_added_in_directory.json"

I think "drive/Directory 1/Sub Directory Folder" and "drive/Directory 1/Sub
Directory Folder/Sub Sub Directory Folder" should be unaffected here.

[achuithb, 2012/11/15 23:57:08]

Note that the delta json file actually has 2 document entries - one for the
newly added file, and one for the parent directory. 

If the parent directory is modified, all the children should be notified. This
is actually broken in TOT, and we are not sending all the correct notifications.
The code at fault is here:
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/chromeos/dri...

Note that we move the existing children from old_entry to the new entry using
TakeOverEntries BEFORE calling RemoveEntryFromParent. RemoveEntryFromParent
attempts to collect the children of old_entry being removed, but there are never
any, because TakeOverEntries has already been called. The code should actually
call GetChildDirectoryPaths first, then TakeOverEntries, and finally
RemoveEntry.

[satorux1, 2012/11/16 06:57:48]

Let's not change the semantics in this patch.

1) The patch is a major refactoring, so changing the behaviors while refactoring
should usually be avoided

2) Notifying children looks wrong. The purpose of changed directories
notification is to update the contents of the current directory shown in
Files.app. There is no need to update the contents if something was changed in a
parent directory or above.

3) mtomasz filed crbug.com/158908 about inconsistency between file watching on 
the local disk and file watching on Drive. We should fix the inconsistency.

[achuithb, 2012/11/16 22:55:56]

Done.

   ASSERT_TRUE(LoadChangeFeed("gdata/delta_file_added_in_directory.json",
                              ++latest_changelog));
   EXPECT_TRUE(EntryExists(FilePath(
@@ -1077,7 +1083,7 @@
   int latest_changelog = 0;
   ASSERT_TRUE(LoadRootFeedDocument("gdata/root_feed.json"));
 
-  // This feed contains thw following updates:
+  // This feed contains the following updates:
   // 1) A new PDF file is added to a new directory
   // 2) but the new directory is marked "deleted" (i.e. moved to Trash)
   // Hence, the PDF file should be just ignored.
@@ -1111,6 +1117,13 @@
   EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(
       Eq(FilePath(FILE_PATH_LITERAL("drive/Directory 2/Directory 1")))))
       .Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL("drive/Directory 1/Sub Directory Folder")))))
+      .Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL(
+          "drive/Directory 1/Sub Directory Folder/Sub Sub Directory Folder")))))
+      .Times(1);

[satorux1, 2012/11/15 01:49:10]

Ditto. Should these directories be affected?

[achuithb, 2012/11/15 23:57:08]

Same as above.

   ASSERT_TRUE(LoadChangeFeed(
       "gdata/delta_dir_moved_from_root_to_directory.json",
       ++latest_changelog));
@@ -1147,6 +1160,13 @@
       Eq(FilePath(FILE_PATH_LITERAL("drive"))))).Times(1);
   EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(
       Eq(FilePath(FILE_PATH_LITERAL("drive/Directory 1"))))).Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL("drive/Directory 1/Sub Directory Folder")))))
+      .Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL(
+          "drive/Directory 1/Sub Directory Folder/Sub Sub Directory Folder")))))
+      .Times(1);
   ASSERT_TRUE(LoadChangeFeed(
       "gdata/delta_file_moved_from_directory_to_root.json",
       ++latest_changelog));
@@ -1176,6 +1196,13 @@
       Eq(FilePath(FILE_PATH_LITERAL("drive"))))).Times(1);
   EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(
       Eq(FilePath(FILE_PATH_LITERAL("drive/Directory 1"))))).Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL("drive/Directory 1/Sub Directory Folder")))))
+      .Times(1);
+  EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(Eq(FilePath(
+      FILE_PATH_LITERAL(
+          "drive/Directory 1/Sub Directory Folder/Sub Sub Directory Folder")))))
+      .Times(1);
   ASSERT_TRUE(LoadChangeFeed("gdata/delta_file_renamed_in_directory.json",
                              ++latest_changelog));