Lose chrome/renderer/prerender/prerendering_support.*

Lose chrome/renderer/prerender/prerendering_support.*

Move the prerendering_support. functionality into the prerender dispatcher, which is the logical place to handle messages from either the browser or WebKit.

This is being done in preparation for adding events on prerenders, which require more connection between the WebKit/browser messaging.

There's no test, as this should be refactoring only.

BUG=none
R=mmenke@chromium.org
TBR=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163960

[gavinp, 2012-10-24 18:41:56]

Matt, WDYT?

[mmenke, 2012-10-24 19:20:09]

LGTM.

http://codereview.chromium.org/11288002/diff/1/chrome/renderer/prerender/prer...
File chrome/renderer/prerender/prerender_dispatcher.h (right):

http://codereview.chromium.org/11288002/diff/1/chrome/renderer/prerender/prer...
chrome/renderer/prerender/prerender_dispatcher.h:40: // from
WebPrerenderingSupport
nit:  Google C++ style guide says "Comments should usually be written as
complete sentences with proper capitalization and periods at the end".  While we
don't strictly enforce that, comments that start with lowercase letters or end
with punctuation (Other than variable names) weird me out.

I don't really care about the format here, but my suggestion is just "From
Blah:", or even "From Blah.".  Or "Blah implementation:"...  Or just keep the
old style.  I'm not picky.

[gavinp, 2012-10-24 20:45:09]

Thanks Matt!

http://codereview.chromium.org/11288002/diff/1/chrome/renderer/prerender/prer...
File chrome/renderer/prerender/prerender_dispatcher.h (right):

http://codereview.chromium.org/11288002/diff/1/chrome/renderer/prerender/prer...
chrome/renderer/prerender/prerender_dispatcher.h:40: // from
WebPrerenderingSupport
On 2012/10/24 19:20:09, Matt Menke wrote:
> nit:  Google C++ style guide says "Comments should usually be written as
> complete sentences with proper capitalization and periods at the end".  While
we
> don't strictly enforce that, comments that start with lowercase letters or end
> with punctuation (Other than variable names) weird me out.
> 
> I don't really care about the format here, but my suggestion is just "From
> Blah:", or even "From Blah.".  Or "Blah implementation:"...  Or just keep the
> old style.  I'm not picky.

Done.

[commit-bot: I haz the power, 2012-10-24 20:45:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/11288002/12001

[commit-bot: I haz the power, 2012-10-24 20:45:27]

Presubmit check for 11288002-12001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[gavinp, 2012-10-24 20:49:32]

+sky

sky: could you LGTM me removing a file from the build?

Thanks!

[sky, 2012-10-24 21:42:26]

LGTM - feel free to TBR me on these in the future.

[gavinp, 2012-10-24 22:02:03]

Sky,

Since this is a .gypi change, I'm TBRing you. Let me know if this is a problem.

[commit-bot: I haz the power, 2012-10-24 22:02:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/11288002/12001

[commit-bot: I haz the power, 2012-10-25 00:03:48]

Change committed as 163960