Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 11284: Match Windows font metrics on Linux. (Closed)

Created:
12 years, 1 month ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Match Windows font metrics on Linux. With this change, many layout tests involving text match render trees exactly. By turning off anti-aliasing we also almost match pixel exact. There are a couple of single-pixel differences between Win32 font rendering and FreeType however (see the bottom left pixel of an 'a' glyph for example), so we aren't quite pixel-for-pixel yet. Mike Reed expects to redo much of the font configuration code in Skia to cope with complex text and subpixel text so, for now, I'm not going to have anti-aliasing be a command line flag etc.

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -18 lines) Patch
M skia/ports/SkFontHost_fontconfig.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M webkit/port/platform/graphics/chromium/FontPlatformDataLinux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/port/platform/graphics/chromium/SimpleFontDataLinux.cpp View 1 1 chunk +6 lines, -10 lines 0 comments Download
A webkit/tools/test_shell/resources/linux-fontconfig-config View 1 chunk +76 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agl
12 years, 1 month ago (2008-11-19 20:00:54 UTC) #1
Evan Martin
LGTM
12 years, 1 month ago (2008-11-19 20:16:12 UTC) #2
Evan Martin
12 years, 1 month ago (2008-11-19 20:16:27 UTC) #3
LGTM with comments this time

http://codereview.chromium.org/11284/diff/201/17
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/11284/diff/201/17#newcode67
Line 67: std::wstring path;
FilePath path;
PathService::...
path = path.Append("webkit/tools/test_shell/...")

path.value()  is a std::string

http://codereview.chromium.org/11284/diff/201/17#newcode80
Line 80: true))
curlies and c++-style casts if you care

Powered by Google App Engine
This is Rietveld 408576698