Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1128013: Fix ChromeFrame referrer test which was flaky due to incorrect http header pa... (Closed)

Created:
10 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix ChromeFrame referrer test which was flaky due to incorrect http header parsing. To pass the referrer to Chrome during navigation we were converting normalized HTTP headers which are terminated with \r\n to raw headers and attempting to parse them. Converting to raw headers basically replaces \r\n with the NULL terminator which causes the parsing to fail as a result of which we fail to retrieve the referrer. Fix is to not convert the headers to raw and just parse the orignal headers. The other change is to only flag success or failure in the referrer frame test if we are running in Chrome. This page loads initially in IE as well due to the vagaries of the http equiv patch. Flagging an error if we don't find a referrer basically causes the test to fail. This should fix http://code.google.com/p/chromium/issues/detail?id=34812 Will remove the flaky attribute on the ChromeFrame Referrer test in a subsequent CL if all goes well. Bug=34812 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42372

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M chrome_frame/test/data/referrer_frame.html View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome_frame/urlmon_moniker.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
10 years, 9 months ago (2010-03-23 05:11:53 UTC) #1
tommi (sloooow) - chröme
lgtm. We need a test that verifies that scripts in CF pages never execute in ...
10 years, 9 months ago (2010-03-23 16:11:59 UTC) #2
tommi (sloooow) - chröme
10 years, 9 months ago (2010-03-23 19:01:56 UTC) #3
lgtm.

Powered by Google App Engine
This is Rietveld 408576698