Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: src/conversions.h

Issue 1128010: Modify FastD2I to use static_cast instead of lrint(). Benchmarks show that it... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/conversions-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 #define V8_CONVERSIONS_H_ 29 #define V8_CONVERSIONS_H_
30 30
31 namespace v8 { 31 namespace v8 {
32 namespace internal { 32 namespace internal {
33 33
34 34
35 // The fast double-to-(unsigned-)int conversion routine does not guarantee 35 // The fast double-to-(unsigned-)int conversion routine does not guarantee
36 // rounding towards zero. 36 // rounding towards zero.
37 // The result is unspecified if x is infinite or NaN, or if the rounded 37 // The result is unspecified if x is infinite or NaN, or if the rounded
38 // integer value is outside the range of type int. 38 // integer value is outside the range of type int.
39 static inline int FastD2I(double x); 39 static inline int FastD2I(double x) {
40 // The static_cast convertion from double to int used to be slow, but
41 // as new benchmarks show, now it is much faster than lrint().
42 return static_cast<int>(x);
43 }
44
40 static inline unsigned int FastD2UI(double x); 45 static inline unsigned int FastD2UI(double x);
41 46
42 47
43 static inline double FastI2D(int x) { 48 static inline double FastI2D(int x) {
44 // There is no rounding involved in converting an integer to a 49 // There is no rounding involved in converting an integer to a
45 // double, so this code should compile to a few instructions without 50 // double, so this code should compile to a few instructions without
46 // any FPU pipeline stalls. 51 // any FPU pipeline stalls.
47 return static_cast<double>(x); 52 return static_cast<double>(x);
48 } 53 }
49 54
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // Additional number to string conversions for the number type. 115 // Additional number to string conversions for the number type.
111 // The caller is responsible for calling free on the returned pointer. 116 // The caller is responsible for calling free on the returned pointer.
112 char* DoubleToFixedCString(double value, int f); 117 char* DoubleToFixedCString(double value, int f);
113 char* DoubleToExponentialCString(double value, int f); 118 char* DoubleToExponentialCString(double value, int f);
114 char* DoubleToPrecisionCString(double value, int f); 119 char* DoubleToPrecisionCString(double value, int f);
115 char* DoubleToRadixCString(double value, int radix); 120 char* DoubleToRadixCString(double value, int radix);
116 121
117 } } // namespace v8::internal 122 } } // namespace v8::internal
118 123
119 #endif // V8_CONVERSIONS_H_ 124 #endif // V8_CONVERSIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/conversions-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698