rlz/lib/financial_ping.cc - Issue 11275284: [cros,rlz] Financial ping livelock fix and proper shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rlz/lib/financial_ping.cc

Issue 11275284: [cros,rlz] Financial ping livelock fix and proper shutdown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Enable on Chromium for testing (DO NOT COMMIT) Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rlz/lib/financial_ping.cc

diff --git a/rlz/lib/financial_ping.cc b/rlz/lib/financial_ping.cc

index 9b7e3194a0ce01e4b0d89d4d5b72716810493e44..9abbd8066a9038bde89c57abe12613d2e4659d28 100644

--- a/rlz/lib/financial_ping.cc

+++ b/rlz/lib/financial_ping.cc

@@ -297,10 +297,11 @@ bool FinancialPing::PingServer(const char* request, std::string* response) {

fetcher->SetRequestContext(g_context);

const base::TimeDelta kTimeout = base::TimeDelta::FromMinutes(5);

+ MessageLoop::ScopedNestableTaskAllower allow_nested(MessageLoop::current());

MessageLoop::current()->PostTask(

FROM_HERE,

base::Bind(&net::URLFetcher::Start, base::Unretained(fetcher.get())));

- MessageLoop::current()->PostNonNestableDelayedTask(

+ MessageLoop::current()->PostDelayedTask(

FROM_HERE, loop.QuitClosure(), kTimeout);

loop.Run();