Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: webkit/glue/resource_request_body.cc

Issue 11275223: net: Change type of UploadData::elements from std::vector to ScopedVector (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: _ Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/resource_request_body.cc
diff --git a/webkit/glue/resource_request_body.cc b/webkit/glue/resource_request_body.cc
index 347af0efd925ac9af4d4e4a5e7c38da2fdcca5fb..215dbde08f02a851899228704aecaf2ae2a869e1 100644
--- a/webkit/glue/resource_request_body.cc
+++ b/webkit/glue/resource_request_body.cc
@@ -63,18 +63,18 @@ net::UploadData* ResourceRequestBody::ResolveElementsAndCreateUploadData(
// bytes for TYPE_BYTES.
upload_data->SetUserData(
this, new base::UserDataAdapter<ResourceRequestBody>(this));
- std::vector<net::UploadElement>* elements =
+ ScopedVector<net::UploadElement>* elements =
upload_data->elements_mutable();
for (size_t i = 0; i < resolved_elements.size(); ++i) {
const Element& element = *resolved_elements[i];
switch (element.type()) {
case Element::TYPE_BYTES:
- elements->push_back(net::UploadElement());
- elements->back().SetToSharedBytes(element.bytes(), element.length());
+ elements->push_back(new net::UploadElement());
+ elements->back()->SetToSharedBytes(element.bytes(), element.length());
break;
case Element::TYPE_FILE:
- elements->push_back(net::UploadElement());
- elements->back().SetToFilePathRange(
+ elements->push_back(new net::UploadElement());
+ elements->back()->SetToFilePathRange(
element.path(),
element.offset(),
element.length(),

Powered by Google App Engine
This is Rietveld 408576698