Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 11275223: net: Change type of UploadData::elements from std::vector to ScopedVector (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: _ Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index bc92e7cf3c03eb1c5effa02ee2d241898491f133..a8a7359f38c762261c0e928296959f712fbf53bc 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -195,13 +195,13 @@ void ExtractRequestInfoBody(const net::URLRequest* request,
keys::kRequestBodyRawKey
};
- const std::vector<net::UploadElement>* elements =
+ const ScopedVector<net::UploadElement>& elements =
request->get_upload()->elements();
bool some_succeeded = false;
for (size_t i = 0; !some_succeeded && i < arraysize(presenters); ++i) {
- std::vector<net::UploadElement>::const_iterator element;
- for (element = elements->begin(); element != elements->end(); ++element)
- presenters[i]->FeedNext(*element);
+ ScopedVector<net::UploadElement>::const_iterator element;
+ for (element = elements.begin(); element != elements.end(); ++element)
+ presenters[i]->FeedNext(**element);
if (presenters[i]->Succeeded()) {
requestBody->Set(kKeys[i], presenters[i]->Result().release());
some_succeeded = true;
« no previous file with comments | « no previous file | chrome/browser/policy/device_management_service_browsertest.cc » ('j') | chrome/common/automation_messages.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698