Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: build/grit_action.gypi

Issue 11275101: Fix branding in chromoting string resources (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/base/resources_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/grit_action.gypi
diff --git a/build/grit_action.gypi b/build/grit_action.gypi
index 0f0d7798e0a42a69374b9670d9c499351547b5df..af1b4d7ac9dd83dccc1f0073d7b055f3f4fa3ec2 100644
--- a/build/grit_action.gypi
+++ b/build/grit_action.gypi
@@ -16,16 +16,19 @@
{
'variables': {
'grit_cmd': ['python', '<(DEPTH)/tools/grit/grit.py'],
+ 'grit_resource_ids%': 'GRIT_DIR/../gritsettings/resource_ids',
tony 2012/11/01 23:29:15 Do you need the %? I thought that meant you could
Sergey Ulanov 2012/11/01 23:34:38 No, grit substitutes GRIT_DIR internally.
tony 2012/11/01 23:36:51 Sorry, I was asking about the % in grit_resource_i
Sergey Ulanov 2012/11/01 23:41:45 % means don't override the variable if it's alread
},
'inputs': [
- '<!@pymod_do_main(grit_info <@(grit_defines) --inputs <(grit_grd_file))',
+ '<!@pymod_do_main(grit_info <@(grit_defines) --inputs <(grit_grd_file) '
+ '-f "<(grit_resource_ids)")',
],
'outputs': [
- '<!@pymod_do_main(grit_info <@(grit_defines) --outputs \'<(grit_out_dir)\' <(grit_grd_file))',
+ '<!@pymod_do_main(grit_info <@(grit_defines) --outputs \'<(grit_out_dir)\' '
+ '<(grit_grd_file) -f "<(grit_resource_ids)")',
],
'action': ['<@(grit_cmd)',
'-i', '<(grit_grd_file)', 'build',
- '-fGRIT_DIR/../gritsettings/resource_ids',
+ '-f', '<(grit_resource_ids)',
'-o', '<(grit_out_dir)',
'<@(grit_defines)' ],
'msvs_cygwin_shell': 0,
« no previous file with comments | « no previous file | remoting/base/resources_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698