Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 11274057: Used the new WebContentLayerClient::paintContents interface. (Closed)

Created:
8 years, 1 month ago by alokp
Modified:
8 years, 1 month ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org, jonathan.backer
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Used the new WebContentLayerClient::paintContents interface. BUG=100666 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164815

Patch Set 1 #

Patch Set 2 : Added HAS_CANPAINTLCDTEXT guard #

Total comments: 2

Patch Set 3 : chrome style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M ui/compositor/layer.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M ui/compositor/layer.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
alokp
In preparation for https://bugs.webkit.org/show_bug.cgi?id=99083
8 years, 1 month ago (2012-10-29 21:56:44 UTC) #1
jamesr
lgtm After landing, remember that you have to roll this in to Source/WebKit/chromium/DEPS in the ...
8 years, 1 month ago (2012-10-29 22:00:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/11274057/2001
8 years, 1 month ago (2012-10-29 22:05:44 UTC) #3
commit-bot: I haz the power
Presubmit check for 11274057-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-10-29 22:05:50 UTC) #4
alokp
piman: OWNERS approval needed for ui/compositor.
8 years, 1 month ago (2012-10-29 22:09:57 UTC) #5
piman
LGTM+nit. Please come back and remove #ifdefs once the webkit side has rolled. http://codereview.chromium.org/11274057/diff/2001/ui/compositor/layer.h File ...
8 years, 1 month ago (2012-10-29 22:19:24 UTC) #6
alokp
http://codereview.chromium.org/11274057/diff/2001/ui/compositor/layer.h File ui/compositor/layer.h (right): http://codereview.chromium.org/11274057/diff/2001/ui/compositor/layer.h#newcode267 ui/compositor/layer.h:267: bool canPaintLCDText, On 2012/10/29 22:19:25, piman wrote: > nit: ...
8 years, 1 month ago (2012-10-29 22:24:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/11274057/9001
8 years, 1 month ago (2012-10-29 22:25:32 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 01:37:54 UTC) #9
Change committed as 164815

Powered by Google App Engine
This is Rietveld 408576698