Refactor video capture to new design

content/renderer/pepper/content_renderer_pepper_host_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/content_renderer_pepper_host_factory.h"
 
 #include "base/logging.h"
 #include "content/renderer/pepper/pepper_file_chooser_host.h"
 #include "content/renderer/pepper/pepper_flash_host.h"
+#include "content/renderer/pepper/pepper_video_capture_host.h"
 #include "content/renderer/pepper/pepper_websocket_host.h"
 #include "content/renderer/pepper/renderer_ppapi_host_impl.h"
 #include "ppapi/host/resource_host.h"
 #include "ppapi/proxy/ppapi_messages.h"
 
 using ppapi::host::ResourceHost;
 
 namespace content {
 
 ContentRendererPepperHostFactory::ContentRendererPepperHostFactory(
@@ skipping 13 matching lines @@
 
   // Make sure the plugin is giving us a valid instance for this resource.
   if (!host_->IsValidInstance(instance))
     return scoped_ptr<ResourceHost>();
 
   // Stable interfaces.
   switch (message.type()) {
     case PpapiHostMsg_WebSocket_Create::ID:
       return scoped_ptr<ResourceHost>(new PepperWebSocketHost(
           host_, instance, params.pp_resource()));
+    case PpapiHostMsg_VideoCapture_Create::ID: {
+      PepperVideoCaptureHost* host = new PepperVideoCaptureHost(

[yzshen1, 2012/10/29 18:34:23]

This is not a stable interface. Add it to the dev section.

[victorhsieh, 2012/10/30 09:43:28]

Done.  BTW, there is TODO before the dev section mentioning a bug, which has
been closed.  Do you think it's safe to remove to TODO and restore the "if" in
this CL?

[yzshen1, 2012/11/06 06:51:40]

I haven't looked into the relevant code. (Brett might know.)
But it is better to be in a different CL and link to the appropriate bug.

[victorhsieh, 2012/11/08 09:20:18]

I see.  Will leave it untouched here.

On 2012/11/06 06:51:40, yzshen1 wrote:

+          host_, instance, params.pp_resource());
+      if (!host->Init()) {
+        delete host;
+        return scoped_ptr<ResourceHost>();
+      }
+      return scoped_ptr<ResourceHost>(host);
+    }
   }
 
   // Resources for dev interfaces.
   // TODO(brettw) when we support any public or private interfaces, put them in
   // a separate switch above.
 
   // TODO(brettw) put back this dev check! This was removed to fix issue 138902
   // where the permissions for bundled Flash (but not Flash that you specify
   // on the command line, making it difficult to test) are incorrect.
   /*if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV))*/ {
@@ skipping 15 matching lines @@
 
   return scoped_ptr<ResourceHost>();
 }
 
 const ppapi::PpapiPermissions&
 ContentRendererPepperHostFactory::GetPermissions() const {
   return host_->GetPpapiHost()->permissions();
 }
 
 }  // namespace content