Added support for YUV videos to the software compositor.

webkit/media/webvideoframe_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_MEDIA_WEBVIDEOFRAME_IMPL_H_
 #define WEBKIT_MEDIA_WEBVIDEOFRAME_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "media/base/video_frame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebVideoFrame.h"
 
 namespace webkit_media {
 
 class WebVideoFrameImpl : public WebKit::WebVideoFrame {
  public:
   // This converts a WebKit::WebVideoFrame to a media::VideoFrame.
   static media::VideoFrame* toVideoFrame(
-      WebKit::WebVideoFrame* web_video_frame);
+      WebVideoFrame* web_video_frame);

[Ami GONE FROM CHROMIUM, 2012/10/26 22:45:09]

optional: Personally I find the previous version more visually useful (as it
matches the comment).

[slavi, 2012/10/26 23:46:23]

Done.

 
   WebVideoFrameImpl(scoped_refptr<media::VideoFrame> video_frame);
   virtual ~WebVideoFrameImpl();
   virtual WebVideoFrame::Format format() const;
   virtual unsigned width() const;
   virtual unsigned height() const;
   virtual unsigned planes() const;
   virtual int stride(unsigned plane) const;
   virtual const void* data(unsigned plane) const;
   virtual unsigned textureId() const;
   virtual unsigned textureTarget() const;
 
  private:
   scoped_refptr<media::VideoFrame> video_frame_;
   DISALLOW_COPY_AND_ASSIGN(WebVideoFrameImpl);
 };
 
+inline media::VideoFrame* WebVideoFrameImpl::toVideoFrame(

[Ami GONE FROM CHROMIUM, 2012/10/26 22:45:09]

Why this thunk?

[slavi, 2012/10/26 23:46:23]

Ok, this is subtle.

The problem is that I want to be able to unwrap WebKit::WebVideoFrame to a
concrete media::VideoFrame in the cc/ module. I can't do this by calling
WebVideoFrameImpl::toVideoFrame directly since WebVideoFrameImpl lives in
webkit/ on which cc/ cannot depend. 

So, I'm passing it a callback from
webkit/compositor_bindings/web_video_layer_impl.cc down to cc/. 

That almost works but it breaks shared lib builds because
WebVideoFrameImpl::toVideoFrame is not marked as EXPORTed and cc/ is trying to
call it from another shared lib.

One way it fix it is to mark WebVideoFrameImpl::toVideoFrame as EXPORTed but I
didn't do it because webkit/ doesn't export anything besides chromium WebKit API
interfaces.

Or, you can just mark it as |inline| and then I get a copy of it in cc/. Subtle
but elegant and works on all platforms and compilers.

+    WebVideoFrame* web_video_frame) {
+  WebVideoFrameImpl* wrapped_frame =
+      static_cast<WebVideoFrameImpl*>(web_video_frame);
+  if (wrapped_frame)
+    return wrapped_frame->video_frame_.get();
+  return NULL;
+}
+
 }  // namespace webkit_media
 
 #endif  // WEBKIT_MEDIA_WEBVIDEOFRAME_IMPL_H_