Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 11273081: Adding a test for measuring memory usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (tonyg, nduca) Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page_interaction.py ('k') | tools/telemetry/telemetry/page_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page_runner.py
diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py
index 827d2662da1679d5465c367b8abbc4c29333b879..9ad5351abdd9be3daff91e6ae83d43c85ae838a2 100644
--- a/tools/telemetry/telemetry/page_runner.py
+++ b/tools/telemetry/telemetry/page_runner.py
@@ -73,6 +73,9 @@ http://goto/read-src-internal, or create a new archive using --record.
if not os.path.exists(credentials_path):
credentials_path = None
+ for page in self.page_set:
+ test.CustomizeBrowserOptionsForPage(page, possible_browser.options)
+
with possible_browser.Create() as b:
b.credentials.credentials_path = credentials_path
test.SetUpBrowser(b)
@@ -101,6 +104,10 @@ http://goto/read-src-internal, or create a new archive using --record.
self._RunPage(options, page, tab, test, results)
def _RunPage(self, options, page, tab, test, results):
+ if not test.CanRunForPage(page):
+ results.AddSkippedPage(page, 'Test cannot run', '')
+ return
+
logging.info('Running %s' % page.url)
page_state = PageState()
« no previous file with comments | « tools/telemetry/telemetry/page_interaction.py ('k') | tools/telemetry/telemetry/page_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698