Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/telemetry/telemetry/inspector_page_unittest.py

Issue 11273081: Adding a test for measuring memory usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (tonyg, nduca) Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/discover.py ('k') | tools/telemetry/telemetry/multi_page_benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/inspector_page_unittest.py
diff --git a/tools/telemetry/telemetry/inspector_page_unittest.py b/tools/telemetry/telemetry/inspector_page_unittest.py
index 33c476e5d76d4de9c1aaba430aab5783bf1ebc2a..8bb9b99f730acd5df9e485cabc0cc27cba94cc74 100644
--- a/tools/telemetry/telemetry/inspector_page_unittest.py
+++ b/tools/telemetry/telemetry/inspector_page_unittest.py
@@ -8,7 +8,6 @@ from telemetry import tab_test_case
class InspectorPageTest(tab_test_case.TabTestCase):
def __init__(self, *args):
super(InspectorPageTest, self).__init__(*args)
- self._custom_action_called = False
def testPageNavigateToNormalUrl(self):
self._tab.page.Navigate('http://www.google.com')
@@ -34,13 +33,13 @@ class InspectorPageTest(tab_test_case.TabTestCase):
self.assertEquals(self._tab.runtime.Evaluate('document.location.pathname;'),
'/page_with_link.html')
- self._custom_action_called = False
+ custom_action_called = [False]
def CustomAction():
- self._custom_action_called = True
+ custom_action_called[0] = True
self._tab.runtime.Execute('document.getElementById("clickme").click();')
self._tab.page.PerformActionAndWaitForNavigate(CustomAction)
- self.assertTrue(self._custom_action_called)
+ self.assertTrue(custom_action_called[0])
self.assertEquals(self._tab.runtime.Evaluate('document.location.pathname;'),
'/blank.html')
« no previous file with comments | « tools/telemetry/telemetry/discover.py ('k') | tools/telemetry/telemetry/multi_page_benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698