The findbugs_diff and lib.

build/android/findbugs_diff.py

+#!/usr/bin/python

[bulach, 2012/10/25 08:30:06]

nit:
#!/usr/bin/env python

[michaelbai, 2012/10/25 21:13:26]

Done.

+#
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Runs findbugs, and returns an error code if there are new warnings.
+This runs findbugs with an additional flag to exclude known bugs.
+To update the list of known bugs, do this:
+
+   findbugs_diff.py --rebaseline
+
+Note that this is separate from findbugs_exclude.xml. The "exclude" file has
+false positives that we do not plan to fix. The "known bugs" file has real
+bugs that we *do* plan to fix (but haven't done so yet).
+
+Other options
+  --only-analyze used to only analyze the class you are interested.

[bulach, 2012/10/25 08:30:06]

nit: how about "filter" ? --only-analyze seems that will do just analyzes and
not something else.

[michaelbai, 2012/10/25 21:13:26]

FindBugs calls exclude xml file as filter file, it might be a little confused if
we use --only-analyze also match the same argument for FindBugs.

From my aspect, it just analyzes the the passed in classes, what did you mean
for something else

On 2012/10/25 08:30:06, bulach wrote:

+  --release analyze the classes in out/Release directory.

[bulach, 2012/10/25 08:30:06]

nit: how about buildtype? then it can have as default:

os.environ.get('BUILDTYPE', 'Debug')

[michaelbai, 2012/10/25 21:13:26]

I'd like use the --release-build, since there are only 2 valid value Debug or
Release, in most cases, we only check Debug, using buildtype force user to input
the correct path name like 'Release' or 'Debug', it is easy to have typo like
'release/debug';

So, it will be simple to use a boolean value '--release-build' to analyze the
'Release' directory, otherwise analyze 'Debug' directory by default.

On 2012/10/25 08:30:06, bulach wrote:

+  --findbugs-args used to passin other findbugs's options.
+
+Run
+  CHROM_SRC/third_party/findbugs/bin/findbugs -textui for details.

[bulach, 2012/10/25 08:30:06]

nit: $CHROME_SRC

[michaelbai, 2012/10/25 21:13:26]

Done.

+
+"""
+
+import optparse
+import os
+import sys
+
+from pylib import findbugs
+

[bulach, 2012/10/25 08:30:06]

nit: need an extra \n

[michaelbai, 2012/10/25 21:13:26]

Done.

+def main(argv):
+  parser = optparse.OptionParser()
+  parser.add_option('-r',
+                    '--rebaseline',
+                    action='store_true',
+                    default=False,

[bulach, 2012/10/25 08:30:06]

nit: "default=False" can be removed here and 52 and 59

[michaelbai, 2012/10/25 21:13:26]

Done.

+                    dest='rebaseline',
+                    help='Rebaseline known findbugs issues.')
+
+  parser.add_option('-o',
+                    '--only-analyze',
+                    action='store',
+                    default=None,
+                    dest='only_analyze',
+                    help='Only analyze the given classes and packages.')
+
+  parser.add_option('-l',
+                    '--release',
+                    action='store_true',
+                    default=False,
+                    dest='release_version',
+                    help='Whether check release version.')
+
+  parser.add_option('-f',
+                    '--findbug-args',
+                    action='store',
+                    default=None,
+                    dest='findbug_args',
+                    help='Additoinal findbug arguments.')

[bulach, 2012/10/25 08:30:06]

nit: Additional

[michaelbai, 2012/10/25 21:13:26]

Done.

+
+  options, _ = parser.parse_args()
+
+  chrome_src = os.getenv('CHROME_SRC')
+
+  known_bugs = os.path.join(chrome_src, 'build', 'android', 'findbugs_filter',

[bulach, 2012/10/25 08:30:06]

nit: maybe have a "baseline_dir" as option? that will make it easier to
integrate downstream..
we could create the option with:
default=os.path.join(chrome_src, 'build', 'android', 'findbugs_filter')
and both here and below would just join with the file name.

[michaelbai, 2012/10/25 21:13:26]

I see your point, you want to use the same script in both upstream and
downstream. If so, I need add --auxclasses argument.  so, in upstream, we need
passin 2 argurments

On 2012/10/25 08:30:06, bulach wrote:

+                            'findbugs_known_bugs.txt')
+  exclude_filter = os.path.join(chrome_src, 'build', 'android',
+                                'findbugs_filter', 'findbugs_exclude.xml')
+
+  only_analyze = options.only_analyze
+  if not only_analyze:
+    only_analyze = 'org.chromium.-'
+
+  return findbugs.Run(exclude_filter, known_bugs, only_analyze,
+                      None, options.rebaseline, options.findbug_args,
+                      options.release_version)
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))