Issue 1127007: Vboot Reference: Add a firmware verification benchmark.

Issue 1127007: Vboot Reference: Add a firmware verification benchmark. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

Vboot Reference: Add a firmware verification benchmark. The benchmark calculates the time taken to verify a firmware image of various sizes for various combinations of signature algorithm. This is meant to be called through autotest.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -17 lines)			Patch
	M	src/platform/vboot_reference/tests/Makefile	View	1	1 chunk	+32 lines, -17 lines	0 comments	Download
	A	src/platform/vboot_reference/tests/firmware_verify_benchmark.c	View	1	1 chunk	+203 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM, assuming it doesn't break build_autotest.sh :-) A couple of suggestions... http://codereview.chromium.org/1127007/diff/1/2 File src/platform/vboot_reference/tests/Makefile (right): ...

10 years, 9 months ago (2010-03-22 22:40:13 UTC) #2

gauravsh

10 years, 9 months ago (2010-03-22 22:49:50 UTC) #3

Submitting.. Another similar code review coming your way. :)

http://codereview.chromium.org/1127007/diff/1/2
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/1127007/diff/1/2#newcode14
src/platform/vboot_reference/tests/Makefile:14: tests: firmware_image_tests
verify_firmware_fuzz_driver \
On 2010/03/22 22:40:13, petkov wrote:
> You have enough targets now to justify having them on separate lines in sorted
> order... Same below with the rules.
> 

Done.

http://codereview.chromium.org/1127007/diff/1/3
File src/platform/vboot_reference/tests/firmware_verify_benchmark.c (right):

http://codereview.chromium.org/1127007/diff/1/3#newcode199
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:199: if
((error_code = SpeedTestAlgorithm(i)))
On 2010/03/22 22:40:13, petkov wrote:
> Not sure what the style says here but, in case it's vague, can you add an
> explicit != 0?
Done.

Expand Messages | Collapse Messages