chrome/browser/ui/gtk/gtk_util.cc - Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/gtk_util.cc

Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebasefinal Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/gtk_util.cc

diff --git a/chrome/browser/ui/gtk/gtk_util.cc b/chrome/browser/ui/gtk/gtk_util.cc

index 151793446386b04e21d9d45c131ec3038c724d39..5c32d6e2f4662469b46c5675b496deaf226f7753 100644

--- a/chrome/browser/ui/gtk/gtk_util.cc

+++ b/chrome/browser/ui/gtk/gtk_util.cc

@@ -484,8 +484,8 @@ void ConvertWidgetPointToScreen(GtkWidget* widget, gfx::Point* p) {

DCHECK(widget);

DCHECK(p);

- gfx::Point position = ui::GetWidgetScreenPosition(widget);

- p->SetPoint(p->x() + position.x(), p->y() + position.y());

+ gfx::Vector2d offset = ui::GetWidgetScreenOffset(widget);

+ *p = p->Add(offset);

danakj 2012/10/29 19:17:20 inlined.

}

GtkWidget* CenterWidgetInHBox(GtkWidget* hbox, GtkWidget* widget,