Add Vector2d classes that represent offsets, instead of using Point.

ui/views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 94 matching lines @@
   // TODO: Remove once NativeTextfield implementations are consolidated to
   // Textfield.
   if (!textfield_->OnMousePressed(event))
     HandleMousePressEvent(event);
   OnAfterUserAction();
   return true;
 }
 
 bool NativeTextfieldViews::ExceededDragThresholdFromLastClickLocation(
     const ui::MouseEvent& event) {
-  gfx::Point location_delta = event.location().Subtract(last_click_location_);
+  gfx::Vector2d location_delta = event.location() - last_click_location_;
   return ExceededDragThreshold(location_delta.x(), location_delta.y());

[Peter Kasting, 2012/10/30 01:14:14]

This may be another function that makes sense to convert to taking a vector,
since we basically want to know "did this drag offset exceed the threshold" and
drag offsets are vectors.

[danakj, 2012/10/30 19:21:21]

Ya for sure. Changed the method. This was a really nice cleanup!

 }
 
 bool NativeTextfieldViews::OnMouseDragged(const ui::MouseEvent& event) {
   // Don't adjust the cursor on a potential drag and drop, or if the mouse
   // movement from the last mouse click does not exceed the drag threshold.
   if (initiating_drag_ || !ExceededDragThresholdFromLastClickLocation(event))
     return true;
 
   OnBeforeUserAction();
   // TODO: Remove once NativeTextfield implementations are consolidated to
@@ skipping 1106 matching lines @@
   // Filter out all control characters, including tab and new line characters,
   // and all characters with Alt modifier. But we need to allow characters with
   // AltGr modifier.
   // On Windows AltGr is represented by Alt+Ctrl, and on Linux it's a different
   // flag that we don't care about.
   return ((ch >= 0x20 && ch < 0x7F) || ch > 0x9F) &&
       (flags & ~(ui::EF_SHIFT_DOWN | ui::EF_CAPS_LOCK_DOWN)) != ui::EF_ALT_DOWN;
 }
 
 }  // namespace views