Add Vector2d classes that represent offsets, instead of using Point.

ui/gfx/rect_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A template for a simple rectangle class.  The containment semantics
 // are array-like; that is, the coordinate (x, y) is considered to be
 // contained by the rectangle, but the coordinate (x + width, y) is not.
 // The class will happily let you create malformed rectangles (that is,
 // rectangles with negative width and/or height), but there will be assertions
 // in the operations (such as Contains()) to complain in this case.
 
 #ifndef UI_GFX_RECT_BASE_H_
 #define UI_GFX_RECT_BASE_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 
 namespace gfx {
 
 template<typename Class,
          typename PointClass,
          typename SizeClass,
          typename InsetsClass,
+         typename VectorClass,
          typename Type>
 class UI_EXPORT RectBase {
  public:
   Type x() const { return origin_.x(); }
   void set_x(Type x) { origin_.set_x(x); }
 
   Type y() const { return origin_.y(); }
   void set_y(Type y) { origin_.set_y(y); }
 
   Type width() const { return size_.width(); }
   void set_width(Type width) { size_.set_width(width); }
 
   Type height() const { return size_.height(); }
   void set_height(Type height) { size_.set_height(height); }
 
   const PointClass& origin() const { return origin_; }
   void set_origin(const PointClass& origin) { origin_ = origin; }
 
   const SizeClass& size() const { return size_; }
   void set_size(const SizeClass& size) { size_ = size; }
 
   Type right() const { return x() + width(); }
   Type bottom() const { return y() + height(); }
 
+  VectorClass OffsetFromOrigin() const {
+    return VectorClass(x(), y());
+  }
+
   void SetRect(Type x, Type y, Type width, Type height);
 
   // Shrink the rectangle by a horizontal and vertical distance on all sides.
   void Inset(Type horizontal, Type vertical) {
     Inset(horizontal, vertical, horizontal, vertical);
   }
 
   // Shrink the rectangle by the given insets.
   void Inset(const InsetsClass& insets);
 
   // Shrink the rectangle by the specified amount on each side.
   void Inset(Type left, Type top, Type right, Type bottom);
 
   // Move the rectangle by a horizontal and vertical distance.
   void Offset(Type horizontal, Type vertical);
-  void Offset(const PointClass& point) {
-    Offset(point.x(), point.y());
+  void Offset(const VectorClass& distance) {
+    Offset(distance.x(), distance.y());
   }
 
   InsetsClass InsetsFrom(const Class& inner) const {
     return InsetsClass(inner.y() - y(),
                        inner.x() - x(),
                        bottom() - inner.bottom(),
                        right() - inner.right());
   }
 
   // Returns true if the area of the rectangle is zero.
@@ skipping 39 matching lines @@
   // Fits as much of the receiving rectangle into the supplied rectangle as
   // possible, becoming the result. For example, if the receiver had
   // a x-location of 2 and a width of 4, and the supplied rectangle had
   // an x-location of 0 with a width of 5, the returned rectangle would have
   // an x-location of 1 with a width of 4.
   void AdjustToFit(const Class& rect);
 
   // Returns the center of this rectangle.
   PointClass CenterPoint() const;
 
+  // Returns the offset to the center of this rectangle from its origin.
+  VectorClass CenterOffset() const {

[Peter Kasting, 2012/10/30 01:14:14]

I'm not convinced of the utility of this and the rest of your change doesn't
seem to use it.  Let's leave it out until a future changelist wants something
like this.

[danakj, 2012/10/30 19:21:21]

k

+    return CenterPoint().OffsetFromOrigin();
+  }
+
   // Becomes a rectangle that has the same center point but with a size capped
   // at given |size|.
   void ClampToCenteredSize(const SizeClass& size);
 
   // Splits |this| in two halves, |left_half| and |right_half|.
   void SplitVertically(Class* left_half, Class* right_half) const;
 
   // Returns true if this rectangle shares an entire edge (i.e., same width or
   // same height) with the given rectangle, and the rectangles do not overlap.
   bool SharesEdgeWith(const Class& rect) const;
 
  protected:
   RectBase(const PointClass& origin, const SizeClass& size);
   explicit RectBase(const SizeClass& size);
   explicit RectBase(const PointClass& origin);
   // Destructor is intentionally made non virtual and protected.
   // Do not make this public.
   ~RectBase();
 
  private:
   PointClass origin_;
   SizeClass size_;
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RECT_BASE_H_