Add Vector2d classes that represent offsets, instead of using Point.

ui/views/controls/table/table_view_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/table/table_view_win.h"
 
 #include <commctrl.h>
 #include <windowsx.h>
 
 #include <algorithm>
@@ skipping 691 matching lines @@
           SetCapture(window);
           return 0;
         }
         // else case, continue on to default handler
       }
       break;
     }
 
     case WM_MOUSEMOVE: {
       if (in_mouse_down) {
-        int x = GET_X_LPARAM(l_param);
-        int y = GET_Y_LPARAM(l_param);
-        if (View::ExceededDragThreshold(x - mouse_down_x, y - mouse_down_y)) {
+        gfx::Point mouse_pos(GET_X_LPARAM(l_param), GET_Y_LPARAM(l_param));
+        gfx::Point mouse_down_pos(mouse_down_x, mouse_down_y);

[Peter Kasting, 2012/10/31 01:04:41]

Nit: Convert mouse_down_x/mouse_down_y from a pair of ints to a point to
eliminate this explicit construction.

You can use CR_DEFINE_STATIC_LOCAL to declare this as a function-level static
without causing any extra static destruction.

[danakj, 2012/10/31 16:55:46]

Oh, fancy.

+        if (View::ExceededDragThreshold(mouse_pos - mouse_down_pos)) {
           // We're about to start drag and drop, which results in no mouse up.
           // Release capture and reset state.
           ReleaseCapture();
           in_mouse_down = false;
 
           NMLISTVIEW details;
           memset(&details, 0, sizeof(details));
           details.hdr.code = LVN_BEGINDRAG;
           SendMessage(::GetParent(window), WM_NOTIFY, 0,
                       reinterpret_cast<LPARAM>(&details));
@@ skipping 916 matching lines @@
 }
 
 void TableSelectionIterator::UpdateModelIndexFromViewIndex() {
   if (view_index_ == -1)
     model_index_ = -1;
   else
     model_index_ = table_view_->ViewToModel(view_index_);
 }
 
 }  // namespace views