Add Vector2d classes that represent offsets, instead of using Point.

ui/base/dragdrop/drag_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/dragdrop/drag_utils.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "googleurl/src/gurl.h"
@@ skipping 75 matching lines @@
 void CreateDragImageForFile(const FilePath& file_name,
                             const gfx::ImageSkia* icon,
                             ui::OSExchangeData* data_object) {
   DCHECK(icon);
   DCHECK(data_object);
   gfx::CanvasImageSource* source = new FileDragImageSource(file_name, *icon);
   gfx::Size size = source->size();
   // ImageSkia takes ownership of |source|.
   gfx::ImageSkia image = gfx::ImageSkia(source, size);
 
-  SetDragImageOnDataObject(image, size,
-                           gfx::Point(size.width() / 2, kLinkDragImageVPadding),
-                           data_object);
+  gfx::Vector2d cursor_offset(size.width() / 2, kLinkDragImageVPadding);

[danakj, 2012/10/29 19:17:20]

Left this, inlining it makes it into a 4-line function all, and having a
variable name here helps document what the vector is representing.

+  SetDragImageOnDataObject(image, size, cursor_offset, data_object);
 }
 
 void SetDragImageOnDataObject(const gfx::Canvas& canvas,
                               const gfx::Size& size,
-                              const gfx::Point& cursor_offset,
+                              const gfx::Vector2d& cursor_offset,
                               ui::OSExchangeData* data_object) {
   gfx::ImageSkia image = gfx::ImageSkia(canvas.ExtractImageRep());
   SetDragImageOnDataObject(image, size, cursor_offset, data_object);
 }
 
 }  // namespace drag_utils