Add Vector2d classes that represent offsets, instead of using Point.

chrome/browser/automation/testing_automation_provider_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <gtk/gtk.h>
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
@@ skipping 19 matching lines @@
                                               static_cast<ViewID>(view_id));
     if (!widget)
       return;
     *success = true;
 
     GtkAllocation allocation;
     gtk_widget_get_allocation(widget, &allocation);
     *bounds = gfx::Rect(allocation.width, allocation.height);
     gint x, y;
     if (screen_coordinates) {
-      gfx::Point point = ui::GetWidgetScreenPosition(widget);
-      x = point.x();
-      y = point.y();
+      gfx::Vector2d offset = ui::GetWidgetScreenOffset(widget);
+      x = offset.x();
+      y = offset.y();

[Peter Kasting, 2012/10/27 01:01:39]

Nit: This causes us to translate back and forth from gint.  How about:

    if (screen_coordinates) {
      bounds->set_origin(gfx::Point() + ui::GetWidgetScreenOffset(widget));
    } else {
      gint x, y;
      gtk_widget_translate_coordinates(widget, GTK_WIDGET(window), 0, 0, &x,
                                       &y);
      bounds->set_origin(gfx::Point(x, y));
    }

[danakj, 2012/10/29 19:17:20]

Done.

     } else {
       gtk_widget_translate_coordinates(widget, GTK_WIDGET(window),
                                        0, 0, &x, &y);
     }
     bounds->set_origin(gfx::Point(x, y));
   }
 }
 
 void TestingAutomationProvider::SetWindowBounds(int handle,
                                                 const gfx::Rect& bounds,
                                                 bool* success) {
   *success = false;
   GtkWindow* window = window_tracker_->GetResource(handle);
   if (window) {
     gtk_window_move(window, bounds.x(), bounds.height());
     gtk_window_resize(window, bounds.width(), bounds.height());
     *success = true;
   }
 }