Add Vector2d classes that represent offsets, instead of using Point.

ash/tooltips/tooltip_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/tooltips/tooltip_controller.h"
 
 #include <vector>
 
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
@@ skipping 432 matching lines @@
   // want to update the tooltip because the timer has fired.
   // If we come here from UpdateTooltip(), we have already checked for tooltip
   // visibility and this check below will have no effect.
   if (tooltip_text_ != tooltip_text || !GetTooltip()->IsVisible()) {
     tooltip_shown_timer_.Stop();
     tooltip_text_ = tooltip_text;
     if (tooltip_text_.empty()) {
       GetTooltip()->Hide();
     } else {
       string16 tooltip_text(tooltip_text_);
       gfx::Point widget_loc = curr_mouse_loc_;

[Peter Kasting, 2012/10/27 01:01:39]

Nit: Inline both of these statements into the SetText() call

[danakj, 2012/10/29 19:17:20]

Done.

       widget_loc = widget_loc.Add(
-          tooltip_window_->GetBoundsInScreen().origin());
+          tooltip_window_->GetBoundsInScreen().OffsetFromOrigin());

[Peter Kasting, 2012/10/27 01:01:39]

Can we replace GetBoundsInScreen() with a function that returns a vector
directly?

[danakj, 2012/10/29 19:17:20]

I don't think we want to replace the method. There's a lot of callers of things
like:
GetBoundsInScreen().CenterPoint()
GetBoundsInScreen().Contains(...)
Intersects(GetBoundsInScreen())

We could add a method along side it, however. Shall we do that in this CL
though? It doesn't seem intrinsic to the change to me, since there are so many
callers of this, and there's no GetPositionInScreen() at the moment to convert.

       GetTooltip()->SetText(tooltip_text, widget_loc);
       GetTooltip()->Show();
       tooltip_shown_timer_.Start(FROM_HERE,
           base::TimeDelta::FromMilliseconds(kTooltipShownTimeoutMs),
           this, &TooltipController::TooltipShownTimerFired);
     }
   }
 }
 
 bool TooltipController::IsTooltipVisible() {
   return GetTooltip()->IsVisible();
 }
 
 bool TooltipController::IsDragDropInProgress() {
   return drag_drop_client_->IsDragDropInProgress();
 }
 
 TooltipController::Tooltip* TooltipController::GetTooltip() {
   if (!tooltip_.get())
     tooltip_.reset(new Tooltip);
   return tooltip_.get();
 }
 
 }  // namespace internal
 }  // namespace ash