Add Vector2d classes that represent offsets, instead of using Point.

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 605 matching lines @@
     if (source != root)
       source->ConvertPointForAncestor(root, point);
   }
 
   if (target != root)
     target->ConvertPointFromAncestor(root, point);
 
   // API defines NULL |source| as returning the point in screen coordinates.
   if (!source) {
     *point = point->Subtract(
-        root->GetWidget()->GetClientAreaBoundsInScreen().origin());
+        root->GetWidget()->GetClientAreaBoundsInScreen().DistanceFromOrigin());

[danakj, 2012/10/26 23:30:34]

We probably want something like GetClientAreaOffsetInScreen() on Widget..

[Peter Kasting, 2012/10/26 23:50:16]

Yes.  I think pretty much any function which has "InScreen" or "ToScreen" or
"FromScreen" anywhere are probably all candidates to convert.  For Widget, if we
can access the client area offset and the client bounds size (or the client
bounds rect in client coordinates, i.e. starting at the origin), we can compute
the client bounds rect in screen coordinates where needed.

   }
 }
 
 // static
 void View::ConvertPointToWidget(const View* src, gfx::Point* p) {
   DCHECK(src);
   DCHECK(p);
 
   src->ConvertPointForAncestor(NULL, p);
 }
@@ skipping 29 matching lines @@
   if (!widget)
     return;
   const gfx::Rect r = widget->GetClientAreaBoundsInScreen();
   p->Offset(-r.x(), -r.y());
   views::View::ConvertPointFromWidget(dst, p);
 }
 
 gfx::Rect View::ConvertRectToParent(const gfx::Rect& rect) const {
   gfx::Rect x_rect = rect;
   GetTransform().TransformRect(&x_rect);
-  x_rect.Offset(GetMirroredPosition());
+  x_rect.Offset(GetMirroredPosition().DistanceFromOrigin());
   return x_rect;
 }
 
 gfx::Rect View::ConvertRectToWidget(const gfx::Rect& rect) const {
   gfx::Rect x_rect = rect;
   for (const View* v = this; v; v = v->parent_)
     x_rect = v->ConvertRectToParent(x_rect);
   return x_rect;
 }
 
@@ skipping 30 matching lines @@
   // we paint our view in its mirrored position if need be.
   gfx::Rect clip_rect = bounds();
   clip_rect.Inset(clip_insets_);
   if (parent_)
     clip_rect.set_x(parent_->GetMirroredXForRect(clip_rect));
   if (!canvas->ClipRect(clip_rect))
     return;
 
   // Non-empty clip, translate the graphics such that 0,0 corresponds to
   // where this view is located (related to its parent).
-  canvas->Translate(GetMirroredPosition());
+  canvas->Translate(GetMirroredPosition().DistanceFromOrigin());
   canvas->Transform(GetTransform());
 
   PaintCommon(canvas);
 }
 
 ui::ThemeProvider* View::GetThemeProvider() const {
   const Widget* widget = GetWidget();
   return widget ? widget->GetThemeProvider() : NULL;
 }
 
@@ skipping 781 matching lines @@
     return;
 
   {
     // If the View we are about to paint requested the canvas to be flipped, we
     // should change the transform appropriately.
     // The canvas mirroring is undone once the View is done painting so that we
     // don't pass the canvas with the mirrored transform to Views that didn't
     // request the canvas to be flipped.
     ScopedCanvas scoped(canvas);
     if (FlipCanvasOnPaintForRTLUI()) {
-      canvas->Translate(gfx::Point(width(), 0));
+      canvas->Translate(gfx::Vector2d(width(), 0));
       canvas->Scale(-1, 1);
     }
 
     OnPaint(canvas);
   }
 
   PaintChildren(canvas);
 }
 
 // Tree operations -------------------------------------------------------------
@@ skipping 588 matching lines @@
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   GetWidget()->RunShellDrag(this, data, widget_location, drag_operations);
   return true;
 #else
   return false;
 #endif  // !defined(OS_MACOSX)
 }
 
 }  // namespace views