Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11267034: Provide IPC mechanism for host-to-resource messaging (Closed)

Created:
8 years, 2 months ago by victorhsieh
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Provide IPC mechanism for host-to-resource messaging BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164577

Patch Set 1 : #

Patch Set 2 : reuse existing dispatch_reply_message.h #

Total comments: 1

Patch Set 3 : else NOTREACHED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -62 lines) Patch
M ppapi/host/dispatch_host_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/dispatch_reply_message.h View 1 2 3 chunks +39 lines, -9 lines 0 comments Download
M ppapi/proxy/websocket_resource.cc View 1 2 chunks +26 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
victorhsieh
Please kindly have a look. My refactoring of video capture will also benefit from this.
8 years, 2 months ago (2012-10-25 07:00:30 UTC) #1
Takashi Toyoshima
Thank you for fixing this. LGTM though I have one optional comment. http://codereview.chromium.org/11267034/diff/11001/ppapi/proxy/dispatch_reply_message.h File ppapi/proxy/dispatch_reply_message.h ...
8 years, 1 month ago (2012-10-25 12:50:39 UTC) #2
victorhsieh
I missed it. Thanks for catching. Brett, when this is ready, would you please submit ...
8 years, 1 month ago (2012-10-25 14:39:03 UTC) #3
brettw
lgtm
8 years, 1 month ago (2012-10-28 18:08:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/11267034/5008
8 years, 1 month ago (2012-10-28 18:08:24 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-29 00:02:18 UTC) #6
Change committed as 164577

Powered by Google App Engine
This is Rietveld 408576698