Chromium Code Reviews| Index: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs |
| diff --git a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs |
| index efa26d00251e1a3cf81985ad3aedcd1f8f657ac1..0feb4d57ee8d7751a47adef74367b333bdbf2127 100644 |
| --- a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs |
| +++ b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs |
| @@ -26,7 +26,7 @@ namespace NativeClientVSAddIn |
| /// <summary> |
| /// The target configuration and platform to read from. |
| /// </summary> |
| - private VCConfiguration configuration_; |
| + public VCConfiguration configuration_; |
|
binji
2012/10/30 20:37:40
why does this need to be public? Also, I think the
Sam Clegg
2012/10/30 21:01:44
Done.
|
| /// <summary> |
| /// Constructs the property manager. Sets the platform type to Other which invalidates use |
| @@ -239,7 +239,16 @@ namespace NativeClientVSAddIn |
| public static bool IsNaClPlatform(string platformName) |
| { |
| return platformName.Equals(Strings.NaCl32PlatformName, StringComparison.OrdinalIgnoreCase) || |
| - platformName.Equals(Strings.NaCl64PlatformName, StringComparison.OrdinalIgnoreCase); |
| + platformName.Equals(Strings.NaCl64PlatformName, StringComparison.OrdinalIgnoreCase) || |
| + platformName.Equals(Strings.PNaClPlatformName, StringComparison.OrdinalIgnoreCase); |
| + } |
| + |
| + /// <summary> |
| + /// Return true if the given platform is the PNaCl platform. |
| + /// </summary> |
| + public bool IsPNaCl() |
| + { |
| + return configuration_.Platform.Name.Equals(Strings.PNaClPlatformName, StringComparison.OrdinalIgnoreCase); |
|
binji
2012/10/30 20:37:40
nit: wrap at 100
Sam Clegg
2012/10/30 21:01:44
Done.
|
| } |
| /// <summary> |