Issue 11265002: Add sync_callbacks.h for Sync FileSystem callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11265002: Add sync_callbacks.h for Sync FileSystem callbacks. (Closed)

Created:
8 years, 2 months ago by tzik

Modified:
8 years, 2 months ago

Reviewers:
kinuko

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add sync_callbacks.h for Sync FileSystem callbacks. BUG=157529, 157530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163772

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	A	webkit/fileapi/syncable/sync_callbacks.h	View		1 chunk	+19 lines, -0 lines	1 comment	Download
	M	webkit/fileapi/webkit_fileapi.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tzik

As a break down patch of another patch[1], I'd like to add a header for ...

8 years, 2 months ago (2012-10-24 02:52:36 UTC) #1

kinuko

lgtm http://codereview.chromium.org/11265002/diff/1/webkit/fileapi/syncable/sync_callbacks.h File webkit/fileapi/syncable/sync_callbacks.h (right): http://codereview.chromium.org/11265002/diff/1/webkit/fileapi/syncable/sync_callbacks.h#newcode17 webkit/fileapi/syncable/sync_callbacks.h:17: } // namespace sync_file_system nit: please put empty ...

8 years, 2 months ago (2012-10-24 03:16:54 UTC) #2

kinuko

On 2012/10/24 03:32:12, kinuko wrote: > Please file a bug for this change. http://code.google.com/p/chromium/issues/detail?id=157529

8 years, 2 months ago (2012-10-24 05:15:25 UTC) #4

tzik

8 years, 2 months ago (2012-10-24 05:21:02 UTC) #5

On 2012/10/24 05:15:25, kinuko wrote:
> On 2012/10/24 03:32:12, kinuko wrote:
> > Please file a bug for this change.
> 
> http://code.google.com/p/chromium/issues/detail?id=157529

Done. crbug.com/157530 (but it's duplicated...)

Expand Messages | Collapse Messages