Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/net/async_dns_field_trial.h

Issue 11262018: Move AsyncDns field trial to server-side control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/net/async_dns_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/async_dns_field_trial.h
diff --git a/chrome/browser/net/async_dns_field_trial.h b/chrome/browser/net/async_dns_field_trial.h
index 48b3945fb0bbebb5ba12d46d17553abcbaf813cb..01bc2775b97ab5593143ee9cf20f60df174a64e9 100644
--- a/chrome/browser/net/async_dns_field_trial.h
+++ b/chrome/browser/net/async_dns_field_trial.h
@@ -5,17 +5,13 @@
#ifndef CHROME_BROWSER_NET_ASYNC_DNS_FIELD_TRIAL_H_
#define CHROME_BROWSER_NET_ASYNC_DNS_FIELD_TRIAL_H_
-#include <string>
-
-class CommandLine;
-class Profile;
-
namespace chrome_browser_net {
-// Configures the AsyncDns field trial as follows.
-// group A (async disabled): use CreateSystemHostResolver
-// group B (async enabled): use CreateAsyncHostResolver
-// Returns true if should use CreateAsyncHostResolver.
+// Returns true if should set |HostResolver::Options::enable_async| to true.
cbentzel 2012/10/25 20:37:16 This comment is a bit unclear. Perhaps Returns t
+// Configures the AsyncDns field trial as follows:
+// groups AsyncDnsA and AsyncDnsB: return true,
+// groups SystemDnsA and SystemDnsB: return false,
+// otherwise (trial absent): return false.
bool ConfigureAsyncDnsFieldTrial();
} // namespace chrome_browser_net
« no previous file with comments | « no previous file | chrome/browser/net/async_dns_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698