Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 11262015: Remove unused / unnecessary stuff from Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove SuggestedTextView entirely Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index 89794ec384156eb1a8d7b3525ffe591717cc5c78..4605e227038a1ebd56e1b928aaa98a93b60571ee 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -524,7 +524,7 @@ void OmniboxViewMac::OnStartingIME() {
// Reset the suggest text just before starting an IME composition session,
// otherwise the IME composition may be interrupted when the suggest text
// gets reset by the IME composition change.
- SetInstantSuggestion(string16(), false);
+ SetInstantSuggestion(string16());
}
bool OmniboxViewMac::OnInlineAutocompleteTextMaybeChanged(
@@ -624,8 +624,7 @@ gfx::NativeView OmniboxViewMac::GetRelativeWindowForPopup() const {
return NULL;
}
-void OmniboxViewMac::SetInstantSuggestion(const string16& suggest_text,
- bool animate_to_complete) {
+void OmniboxViewMac::SetInstantSuggestion(const string16& suggest_text) {
NSString* text = GetNonSuggestTextSubstring();
bool needs_update = (suggest_text_length_ > 0);
@@ -691,7 +690,7 @@ bool OmniboxViewMac::OnDoCommandBySelector(SEL cmd) {
// Reset the suggest text for any change other than key right or tab.
// TODO(rohitrao): This is here to prevent complications when editing text.
// See if this can be removed.
- SetInstantSuggestion(string16(), false);
+ SetInstantSuggestion(string16());
}
if (cmd == @selector(deleteForward:))
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h ('k') | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698