git-cl: show dirty files if any

git_cl.py

Index: git_cl.py
===================================================================
--- git_cl.py	(revision 163751)
+++ git_cl.py	(working copy)
@@ -150,6 +150,17 @@
   parser.parse_args = Parse
 
 
+def is_dirty_git_tree(cmd, force=False):

[M-A Ruel, 2012/10/25 02:26:33]

Remove the force argument.

[ukai, 2012/10/25 02:29:47]

Done.

+  # Make sure index is up-to-date before running diff-index.
+  RunGit(['update-index', '--refresh', '-q'], error_ok=True)
+  dirty = RunGit(['diff-index', '--name-status', 'HEAD'])
+  if not force and dirty:
+    print 'Cannot %s with a dirty tree. You must commit locally first.' % cmd
+    print 'Uncommitted files:'
+    print dirty
+    return True
+  return False
+
 def MatchSvnGlob(url, base_url, glob_spec, allow_wildcards):
   """Return the corresponding git ref if |base_url| together with |glob_spec|
   matches the full |url|.
@@ -997,12 +1008,8 @@
                     help='Run checks even if tree is dirty')
   (options, args) = parser.parse_args(args)
 
-  # Make sure index is up-to-date before running diff-index.
-  RunGit(['update-index', '--refresh', '-q'], error_ok=True)
-  if not options.force and RunGit(['diff-index', 'HEAD']):
-    # TODO(maruel): Is this really necessary?
-    print ('Cannot presubmit with a dirty tree.\n'
-          'You must commit locally first (or use --force).')
+  if is_dirty_git_tree('presubmit', force=options.force):

[M-A Ruel, 2012/10/25 02:26:33]

if not options.force and is_dirty_git_tree('presubmit'):

[ukai, 2012/10/25 02:29:47]

Done.

+    print 'use --force to check even if tree is dirty.'
     return 1
 
   cl = Changelist()
@@ -1199,10 +1206,7 @@
         'In the near future, -m or --message will send a message instead.\n'
         'See http://goo.gl/JGg0Z for details.\n')
 
-  # Make sure index is up-to-date before running diff-index.
-  RunGit(['update-index', '--refresh', '-q'], error_ok=True)
-  if RunGit(['diff-index', 'HEAD']):
-    print 'Cannot upload with a dirty tree.  You must commit locally first.'
+  if is_dirty_git_tree('upload'):
     return 1
 
   cl = Changelist()
@@ -1272,10 +1276,7 @@
   base_branch = args[0]
   base_has_submodules = IsSubmoduleMergeCommit(base_branch)
 
-  # Make sure index is up-to-date before running diff-index.
-  RunGit(['update-index', '--refresh', '-q'], error_ok=True)
-  if RunGit(['diff-index', 'HEAD']):
-    print 'Cannot %s with a dirty tree.  You must commit locally first.' % cmd
+  if is_dirty_git_tree(cmd):
     return 1
 
   # This rev-list syntax means "show all commits not in my branch that