Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: remoting/host/desktop_environment.h

Issue 11260053: Use correct thread for audio capturing and encoding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_environment.h
diff --git a/remoting/host/desktop_environment.h b/remoting/host/desktop_environment.h
index 503f6671979ee44184cfd8cb202e2903bb5c7a51..810d0cef136633aee0f15b7e865ae4d015dbb4ec 100644
--- a/remoting/host/desktop_environment.h
+++ b/remoting/host/desktop_environment.h
@@ -16,26 +16,25 @@ class VideoFrameCapturer;
namespace protocol {
class ClipboardStub;
-}
+} // namespace protocol
class DesktopEnvironment {
public:
- DesktopEnvironment(scoped_ptr<AudioCapturer> audio_capturer,
- scoped_ptr<EventExecutor> event_executor,
+ DesktopEnvironment(scoped_ptr<EventExecutor> event_executor,
scoped_ptr<VideoFrameCapturer> video_capturer);
virtual ~DesktopEnvironment();
- AudioCapturer* audio_capturer() const { return audio_capturer_.get(); }
EventExecutor* event_executor() const { return event_executor_.get(); }
+
+ // TODO(sergeyu): Replace this with a method that creates a new VideoCapturer.
VideoFrameCapturer* video_capturer() const { return video_capturer_.get(); }
virtual void Start(
scoped_ptr<protocol::ClipboardStub> client_clipboard);
- private:
- // Used to capture audio to deliver to clients.
- scoped_ptr<AudioCapturer> audio_capturer_;
+ scoped_ptr<AudioCapturer> CreateAudioCapturer();
Wez 2012/10/27 03:43:15 nit: We should make this interface pure virtual an
Sergey Ulanov 2012/10/29 23:43:04 I think it's better to do it in a separate CL.
+ private:
// Executes input and clipboard events received from the client.
scoped_ptr<EventExecutor> event_executor_;

Powered by Google App Engine
This is Rietveld 408576698