Use correct thread for audio capturing and encoding.

remoting/host/desktop_environment.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/desktop_environment.h"
 
 #include "base/compiler_specific.h"
 #include "remoting/host/audio_capturer.h"
 #include "remoting/host/desktop_environment.h"
 #include "remoting/host/event_executor.h"
 #include "remoting/host/video_frame_capturer.h"
 
 namespace remoting {
 
 DesktopEnvironment::DesktopEnvironment(
-    scoped_ptr<AudioCapturer> audio_capturer,
     scoped_ptr<EventExecutor> event_executor,
     scoped_ptr<VideoFrameCapturer> video_capturer)
-    : audio_capturer_(audio_capturer.Pass()),
-      event_executor_(event_executor.Pass()),
+    : event_executor_(event_executor.Pass()),
       video_capturer_(video_capturer.Pass()) {
 }
 
 DesktopEnvironment::~DesktopEnvironment() {
   event_executor_.release()->StopAndDelete();
 }
 
 void DesktopEnvironment::Start(
     scoped_ptr<protocol::ClipboardStub> client_clipboard) {
   event_executor_->Start(client_clipboard.Pass());
 }
 
+scoped_ptr<AudioCapturer> DesktopEnvironment::CreateAudioCapturer() {

[Wez, 2012/10/27 03:43:15]

We could remove the requirement for DesktopEnvironment to remain valid for the
Audio/VideoScheduler's lifetime by passing a TaskRunner and callback to this
Create...() API; the scheduler would make the create call during the ctor, and
be called back on the selected TaskRunner with the resulting capturer.

[Sergey Ulanov, 2012/10/29 23:43:04]

Not sure if it's a good idea - it would only make DesktopEnvironment
implementation more complicated, and will require making DesktopEnvironment
ref-counted, at least internally. Looks like it would be better to just make
DesktopEnvironment ref-counted.

[Wez, 2012/10/30 03:43:04]

You wouldn't need to ref-count DesktopEnvironment - it would only be reference
by the Audio/VideoScheduler ctor, to call the Create method.  The scheduler
would pass in the callback to be invoked once creation completes, and the
TaskRunner to call it on.

[Sergey Ulanov, 2012/10/30 18:47:25]

Right, but DesktopEnvironment would still need to switch threads internally,
which will require a ref-counted object.

+  return AudioCapturer::Create();
+}
+
 }  // namespace remoting